Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-10804) option to force purge source.lists file #948

Merged
merged 2 commits into from
Sep 14, 2020
Merged

(MODULES-10804) option to force purge source.lists file #948

merged 2 commits into from
Sep 14, 2020

Conversation

sheenaajay
Copy link

@sheenaajay sheenaajay commented Sep 10, 2020 •
edited
Loading

Request for a review
This PR addressed the ticket https://tickets.puppetlabs.com/browse/MODULES-10804
Added changes for both behaviour by adding new parameter sources_list_force for force purge.By default its set to false.
Added unit tests to verify the changes.
As of now the unit tests are failing on apt module on main branch, A ticket is opened for the failures. https://tickets.puppetlabs.com/browse/IAC-1143
Added temporary workaround as mentioned in the above ticket.
Submitting the changes for review since the unit tests failures are not from this PR.
Attaching the release check from both puppet agent 5 and puppet agent 6
Screenshot 2020-09-11 at 10 50 18
Screenshot 2020-09-11 at 11 24 38

@puppet-community-rangefinder
Copy link

apt is a class

Breaking changes to this file WILL impact these 236 modules (exact match):
Breaking changes to this file MAY impact these 47 modules (near match):

apt::params is a class

that may have no external impact to Forge modules.

This module is declared in 233 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sheenaajay sheenaajay marked this pull request as ready for review September 10, 2020 13:47
@sheenaajay sheenaajay requested a review from a team as a code owner September 10, 2020 13:47
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@2e794c9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage        ?   71.86%           
=======================================
  Files           ?        5           
  Lines           ?      263           
  Branches        ?        0           
=======================================
  Hits            ?      189           
  Misses          ?       74           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e794c9...46298a0. Read the comment docs.

@carabasdaniel carabasdaniel merged commit 8038d0a into puppetlabs:main Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianiurca adrianiurca adrianiurca approved these changes

@carabasdaniel carabasdaniel carabasdaniel approved these changes

Assignees
No one assigned
Labels
bugfix feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheenaajay @carabasdaniel @adrianiurca