Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver version bump after Chrome 74 failures #6094

Closed
wants to merge 6 commits into from
Closed

chromedriver version bump after Chrome 74 failures #6094

wants to merge 6 commits into from

Conversation

grvsachdeva
Copy link
Member

@grvsachdeva grvsachdeva commented Aug 1, 2019 •
edited by jywarren
Loading

Addressing #6095 in the short term, follow up there for longer-term fix

@grvsachdeva grvsachdeva force-pushed the refactor/chromedriver-version-bump branch from cc01d35 to 4256127 Compare August 1, 2019 20:13
@jywarren jywarren mentioned this pull request Aug 2, 2019
Open
@jywarren
Copy link
Member

jywarren commented Aug 2, 2019

Nice, and noting # https://sites.google.com/a/chromium.org/chromedriver/ has all versions

@jywarren
Copy link
Member

jywarren commented Aug 2, 2019

Noting specific error: (unknown error: DevToolsActivePort file doesn't exist)

@jywarren
Copy link
Member

jywarren commented Aug 2, 2019

https://stackoverflow.com/questions/50642308/webdriverexception-unknown-error-devtoolsactiveport-file-doesnt-exist-while-t ...says that ...implies that the ChromeDriver was unable to initiate/spawn a new WebBrowser i.e. Chrome Browser session.

It suggests:

However as per Add --disable-dev-shm-usage to default launch flags seems adding the argument --disable-dev-shm-usage will temporary solve the issue.

linking to puppeteer/puppeteer#1834

jywarren
jywarren reviewed Aug 2, 2019
View reviewed changes
test/application_system_test_case.rb
@@ -1,7 +1,7 @@
require "test_helper"

class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
chromeOptions = %w(--headless --disable-gpu --no-sandbox --remote-debugging-port=9222)
chromeOptions = %w(--headless --disable-gpu --no-sandbox --disable-dev-shm-usage --remote-debugging-port=9222)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this change here...

jywarren
jywarren reviewed Aug 2, 2019
View reviewed changes
Dockerfile
@@ -30,7 +30,7 @@ RUN apt-get install -y fonts-liberation libappindicator3-1 libasound2 libatk-bri
RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb && \
dpkg -i google-chrome-stable_current_amd64.deb && \
apt-get -fy install && \
wget https://chromedriver.storage.googleapis.com/74.0.3729.6/chromedriver_linux64.zip && \
wget https://chromedriver.storage.googleapis.com/76.0.3809.68/chromedriver_linux64.zip && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to match this to our chrome version; see #5525 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so:

Unpacking google-chrome-stable (76.0.3809.87-1) ...
2700Setting up google-chrome-stable (76.0.3809.87-1) ...
2701update-alternatives: using /usr/bin/google-chrome-stable to provide /usr/bin/x-www-browser (x-www-browser) in auto mode
2702update-alternatives: using /usr/bin/google-chrome-stable to provide /usr/bin/gnome-www-browser (gnome-www-browser) in auto mode
2703update-alternatives: using /usr/bin/google-chrome-stable to provide /usr/bin/google-chrome (google-chrome) in auto mode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that should be ok...

@jywarren
Copy link
Member

jywarren commented Aug 2, 2019

Possibly connected karma-runner/karma-chrome-launcher#198

@jywarren jywarren changed the title chromedriver version bump chromedriver version bump after Chrome 74 failures Aug 2, 2019
@jywarren
Copy link
Member

jywarren commented Aug 2, 2019

I think we may be seeing a broader issue, re the error (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)

Some have said using --disable-dev-shm-usage fixed the problem, but not for us!

@jywarren
Copy link
Member

jywarren commented Aug 2, 2019

Some people are downgrading to 75.0.3770.140... i'll try this.

jywarren
jywarren reviewed Aug 2, 2019
View reviewed changes
Dockerfile
@@ -30,7 +30,7 @@ RUN apt-get install -y fonts-liberation libappindicator3-1 libasound2 libatk-bri
RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to change the version here to fix it to a specific chrome version, but I can't find a version-pegged link to substitute instead of https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -- hmm!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe https://chromereleases.googleblog.com/ or ah! Here!

https://www.chromium.org/getting-involved/download-chromium

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. That says old versions are not provided as they lack security updates. It shows a pathway to finding old binaries but it's complicated and I wasn't able to find one for 75 on my first try. I feel like it's not a best practice to point at old chromes, but we're stuck as chromedriver isn't working.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I'm stuck here, i can't find an old version for chrome 75-- so can't make this change:

    wget https://chromedriver.storage.googleapis.com/75.0.3770.140/chromedriver_linux64.zip && \

Do we just wait a bit for a solution?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.chromium.org/getting-involved/download-chromium shows methods for finding old Chromes. We could try to find a direct link to an old chrome v74 to just get our Travis running again...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, found a chrome 74 to point to: https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Linux_x64/638880/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Linux_x64%2F638880%2Fchrome-linux.zip?generation=1552011881622744&alt=media ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, trying the above link

@grvsachdeva
Copy link
Member Author

Yeah, I tried all chrome-driver versions after 73 and none of them seems to work. So, bumping chrome version maybe tried.

@jywarren jywarren mentioned this pull request Aug 3, 2019
Merged
@alaxalves
Copy link
Member

Ok, I have recently dealt with something like this in https://gitlab.com/noosfero/noosfero/merge_requests/1687/diffs#diff-content-0ec615393fffd605e287c92d72dc85217af8d1dd I'll push on top of this.

@grvsachdeva
Copy link
Member Author

Great @alaxalves!

@grvsachdeva
Copy link
Member Author

grvsachdeva commented Aug 3, 2019 •
edited
Loading

Although, I am all eyes here, but please ping me if your fix works, as we want to merge it asap. Thank you!

@alaxalves
Copy link
Member

alaxalves commented Aug 3, 2019 •
edited
Loading

Although, I am all eyes here, but please ping me if your fix works, as we want to merge it asap. Thank you!

@gauravano @jywarren Fixed this here -> #6099

@grvsachdeva grvsachdeva closed this Aug 3, 2019
@grvsachdeva grvsachdeva deleted the refactor/chromedriver-version-bump branch August 3, 2019 19:37
@grvsachdeva
Copy link
Member Author

Great. Waiting for tests to end 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grvsachdeva @jywarren @alaxalves