-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply By Tweet Debugging #6093
Reply By Tweet Debugging #6093
Conversation
@gauravano can we merge this? |
Restarted travis. |
It's failing for all PRs @namangupta01 |
Oh okay. So it's not related to mine. We can merge this then? |
urls.each do |url| | ||
puts ">>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>" | ||
puts "url.include? https:// -> #{url.include? "https://"}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could use the start_with? string method instead of include? !
next unless url.include? "https://" | ||
|
||
if url.last == "." | ||
url = url[0...url.length - 1] | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here (lines 452 and 453) you could use the end_with? and chomp methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, @seabl!
Hi @namangupta01 i'm afraid I'd prefer to not merge a failing build, as it can mask other errors being merged. Can you try helping to solve #6094 do you think, as this is an urgent situation for all contributors? Alternatively, is there really no way to test this happening in your dev environment or in unstable? Perhaps @SidharthBansal may be able to suggest a clever way to test it. Just to be clear, is it possible to get working locally in production mode, or in unstable? Thanks! |
I only have a couple of concern while testing on |
Sure I will have look at #6094 and try to solve it along with you guys. |
In the original issue #4962 (i
think) I mentioned some specific tweets you can use. The other option is to
try pointing at a different Twitter account on unstable, like your own, and
to test there using a new user account on unstable, and posting a new test
note.
…On Sat, Aug 3, 2019 at 10:06 AM Naman Gupta ***@***.***> wrote:
Sure I will have look at #6094
<#6094> and try to solve it along
with you guys.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6093?email_source=notifications&email_token=AAAF6J5KHWC4H5LTSWSNS2LQCUU33A5CNFSM4IIUEC62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PIX6Y#issuecomment-517901307>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZTYY7KHXIZG4HZHETQCUU33ANCNFSM4IIUEC6Q>
.
|
Hi, I tried this on local with a tweet from one of my account and replied to that tweet from another account and I was able to find the node from that tweet but in Production, I am not able to. I need a couple of information to get it fix and running it on production. First is what is the environment variable |
OK, i'll pull those data now!
WEBSITE_HOST_PATTERN=://publiclab.org/n/
For my twitter oauth i got: `oauth:twitter:15024966` - you can see it on my
profile page!
…On Fri, Aug 9, 2019 at 1:00 AM Naman Gupta ***@***.***> wrote:
Hi, I tried this on local with a tweet from one of my account and replied
to that tweet from another account and I was able to find the node from
that tweet but in Production, I am not able to. I need a couple of
information to get it fix and running it on production. First is what is
the environment variable ENV["WEBSITE_HOST_PATTERN"] setted in there and
second is what is the data we store in UserTag when we do login via twitter
-- I need this just to confirm that everything will work fine on production
because I am not able to run login via twitter on local and get that value.
I guess these are the small things that we have to look into it.
Afterwards, it will be good to run.
Also having discussion at #6085
<#6085>
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6093?email_source=notifications&email_token=AAAF6J6FHZETBHJQ2M2436DQDRUJXA5CNFSM4IIUEC62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD34S3GY#issuecomment-519646619>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J5BWQQMRPH3YKIYSE3QDRUJXANCNFSM4IIUEC6Q>
.
|
Thanks! Is this also same in stable.publiclab.org i.e WEBSITE_HOST_PATTERN=://publiclab.org/n/ |
Yes, it is the case there too!
…On Fri, Aug 9, 2019 at 1:34 PM Naman Gupta ***@***.***> wrote:
Thanks! Is this also same in stable.publiclab.org i.e
WEBSITE_HOST_PATTERN=://publiclab.org/n/
Because I am downloading logs from
http://stable.publiclab.org/cron_log1.log
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6093?email_source=notifications&email_token=AAAF6J4IM6GHHO4RYAPE3KLQDUMXLA5CNFSM4IIUEC62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD353W7Q#issuecomment-519814014>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J2UQVPLZIMFXBNOPIDQDUMXLANCNFSM4IIUEC6Q>
.
|
It is weird. When I set the same on local I get the node id extracted from the link. |
Can we also merge this? Since I have tested on local and it's able to identify the node_id easily which it is not getting on production on checking logs? What do you think? |
Yes! No danger that we'll fill up logs too fast or anything else to watch out for? Thanks! |
I guess it's fine. But please open up an issue pointing to this PR so that we remember to take out these comments too! Thanks! |
OK, i hope to publish today but not sure. Thanks! |
I'll leave a note in the chatroom if we manage to! |
Thanks!!! I will create a new issue for removing these comments so that we know we have to remove these comments. |
Hoping this could give us enough information to find out what is wrong exactly. Otherwise, we have to dig for more logs. |
No description provided.