try system test to count navbar typeahead results in dropdown #5525

jywarren · 2019-04-18T17:01:11Z

plotsbot · 2019-04-18T17:15:40Z

	1 Message
📖	@jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

jywarren · 2019-04-22T22:53:16Z

[Screenshot]: tmp/screenshots/failures_test_searching_using_navbar_autocomplete.png
 FAIL["test_searching_using_navbar_autocomplete", #<Minitest::Reporters::Suite:0x00007fd458c10460 @name="SearchTest">, 33.867744201999926]
 test_searching_using_navbar_autocomplete#SearchTest (33.87s)
        Expected false to be truthy.
        test/system/search_test.rb:19:in `block in <class:SearchTest>'

jywarren · 2019-04-22T22:56:29Z

test/system/search_test.rb

+
+    fill_in("searchform_input", with: "Canon")
+
+    assert page.evaluate_script("$('.typeahead.dropdown-menu').is(':visible')")


Looks like Capybara won't wait unless we ask it to look for a selector. Even then we can increase the max time:

select('Item that is being loaded', wait: 10)

https://stackoverflow.com/questions/36536111/waiting-for-ajax-with-capybara-poltergeist

also see https://www.rubydoc.info/github/jnicklas/capybara/Capybara/Node/Matchers#assert_selector-instance_method

for example: page.assert_selector('li', text: 'Horse', visible: true)

jywarren · 2019-04-22T23:20:22Z

[Screenshot]: tmp/screenshots/failures_test_searching_using_navbar_autocomplete.png
ERROR["test_searching_using_navbar_autocomplete", #<Minitest::Reporters::Suite:0x00007fcca2808c18 @name="SearchTest">, 18.193436125000062]
 test_searching_using_navbar_autocomplete#SearchTest (18.19s)
Capybara::ElementNotFound:         Capybara::ElementNotFound: Unable to find select box "typeahead.dropdown-menu" that is not disabled and Unable to find input box with datalist completion "typeahead.dropdown-menu" that is not disabled
            test/system/search_test.rb:19:in `block in <class:SearchTest>'

jywarren · 2019-04-23T00:00:48Z

test/system/search_test.rb

+
+    fill_in("searchform_input", with: "Canon")
+
+    assert_select 'typeahead.dropdown-menu' do


Hmm

FAIL["test_searching_using_navbar_autocomplete", #<Minitest::Reporters::Suite:0x00007f8136b478c8 @name="SearchTest">, 10.584121601999982] test_searching_using_navbar_autocomplete#SearchTest (10.58s) expected to find select box "typeahead.dropdown-menu" that is not disabled but there were no matches test/system/search_test.rb:19:in `block in <class:SearchTest>'

what am I doing wrong here? so close!

jywarren · 2019-04-23T03:33:43Z

 FAIL["test_searching_using_navbar_autocomplete", #<Minitest::Reporters::Suite:0x000055c70cd8ee00 @name="SearchTest">, 148.193087525]
 test_searching_using_navbar_autocomplete#SearchTest (148.19s)
        expected to find select box ".typeahead" that is not disabled but there were no matches
        test/system/search_test.rb:19:in `block in <class:SearchTest>'

jywarren · 2019-04-24T01:41:06Z

Hmm. I can't seem to get this to wait for the typeahead dropdown to appear. Capybara is supposed to wait 2 seconds, and i even extended it to 10 seconds. Is it possible I've set this up wrong? I'm trying to detect when the .typeahead element appears when you type a search term into the navbar. @siaw23 do you have any experience with Capybara tests?

jywarren · 2019-04-24T01:43:53Z

OMG wait! This error is different!


 FAIL["test_searching_using_navbar_autocomplete", #<Minitest::Reporters::Suite:0x00005600b8c466c0 @name="SearchTest">, 143.99473105099992]
 test_searching_using_navbar_autocomplete#SearchTest (143.99s)
        Expected: 1
          Actual: 4
        test/system/search_test.rb:22:in `block in <class:SearchTest>'

Four matches! I can do this!

jywarren · 2019-04-24T02:22:45Z

Oh bummer!

ERROR["test_searching_an_item_from_the_homepage", #<Minitest::Reporters::Suite:0x000055d3d1040a38 @name="SearchTest">, 103.21799982900006]
 test_searching_an_item_from_the_homepage#SearchTest (103.22s)
Selenium::WebDriver::Error::SessionNotCreatedError:         Selenium::WebDriver::Error::SessionNotCreatedError: session not created: Chrome version must be between 70 and 73
          (Driver info: chromedriver=73.0.3683.68 (47787ec04b6e38e22703e856e101e840b65afe72),platform=Linux 4.4.0-101-generic x86_64)
            test/system/search_test.rb:6:in `block in <class:SearchTest>'
ERROR["test_searching_using_navbar_autocomplete", #<Minitest::Reporters::Suite:0x000055d3d0f919c0 @name="SearchTest">, 104.00540367200006]
 test_searching_using_navbar_autocomplete#SearchTest (104.01s)
Selenium::WebDriver::Error::SessionNotCreatedError:         Selenium::WebDriver::Error::SessionNotCreatedError: session not created: Chrome version must be between 70 and 73
          (Driver info: chromedriver=73.0.3683.68 (47787ec04b6e38e22703e856e101e840b65afe72),platform=Linux 4.4.0-101-generic x86_64)
            test/system/search_test.rb:15:in `block in <class:SearchTest>'

I wonder if it's related to #5507 or #5509...

jywarren · 2019-04-24T02:29:03Z

https://stackoverflow.com/questions/54302103/selenium-common-exceptions-sessionnotcreatedexception-message-session-not-crea

https://stackoverflow.com/questions/33155562/selenium-webdriver-sessionnotcreatederror

https://stackoverflow.com/questions/54158167/circleci-webdriver-chrome-version-must-be-between-70-and-73

jywarren · 2019-04-24T02:31:26Z

I think we need to match the chrome version with:

plots2/.travis.yml

Line 36 in 94cb7c6

    
           - docker-compose exec web bash -c "wget https://chromedriver.storage.googleapis.com/73.0.3683.68/chromedriver_linux64.zip" # https://sites.google.com/a/chromium.org/chromedriver/

We're using chrome stable: Unpacking google-chrome-stable (74.0.3729.108-1) ...

So, i think we need to change the travis.yml line here:

plots2/.travis.yml

Line 34 in 94cb7c6

    
           - docker-compose exec web bash -c "wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb"

to chrome 73?

jywarren · 2019-04-24T02:38:37Z

Chromedriver went to v2.46 in Feb 2019, and then the version numbering changed, perhaps to match Chrome versions?

https://chromedriver.storage.googleapis.com/

Or the latest seems to support Chrome 74:

https://chromedriver.storage.googleapis.com/74.0.3729.6/notes.txt

We were on 73.0.3683.68, but Chrome 74 was released. I'll try upgrading. We may want to peg these version numbers...

jywarren · 2019-04-24T02:56:29Z

😄

…lab#5525) * try system test to count navbar typeahead results in dropdown * Update search_test.rb * add wait * Update search_test.rb * Update search_test.rb * Update search_test.rb * , wait: 10 * search for 4 li elements * chromedriver 74.0.3729.6

try system test to count navbar typeahead results in dropdown

a7ce56e

jywarren mentioned this pull request Apr 18, 2019

Brainstorm a list of critical full-stack system tests we should add #5316

Closed

13 tasks

Update search_test.rb

6f745f4

jywarren mentioned this pull request Apr 22, 2019

Added test for login case #5410 #5579

Merged

5 tasks

jywarren commented Apr 22, 2019

View reviewed changes

add wait

dcabe7d

jywarren mentioned this pull request Apr 22, 2019

Preserve return_to param when switching from /login to /signup #5559

Merged

5 tasks

Update search_test.rb

9d857e6

SidharthBansal mentioned this pull request Apr 22, 2019

System test for Preserve return_to param when switching from /login to /signup #5585

Closed

jywarren commented Apr 23, 2019

View reviewed changes

Update search_test.rb

046c692

jywarren added 2 commits April 22, 2019 23:39

Update search_test.rb

ab5172e

, wait: 10

1fbbe70

search for 4 li elements

582d244

This was referenced Apr 24, 2019

Try system testing image upload in comments #5526

Closed

Create post_test.rb to test posting at /post #5605

Merged

chromedriver 74.0.3729.6

da3ef8f

jywarren merged commit 099a1ab into master Apr 24, 2019

jywarren mentioned this pull request Aug 2, 2019

chromedriver version bump after Chrome 74 failures #6094

Closed

cesswairimu deleted the system-dropdown branch May 4, 2021 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

try system test to count navbar typeahead results in dropdown #5525

try system test to count navbar typeahead results in dropdown #5525

jywarren commented Apr 18, 2019

plotsbot commented Apr 18, 2019 •

edited

Loading

jywarren commented Apr 22, 2019

jywarren Apr 22, 2019

jywarren Apr 22, 2019

jywarren Apr 23, 2019

jywarren commented Apr 22, 2019

jywarren Apr 23, 2019

jywarren commented Apr 23, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019


		fill_in("searchform_input", with: "Canon")

		assert page.evaluate_script("$('.typeahead.dropdown-menu').is(':visible')")


		fill_in("searchform_input", with: "Canon")

		assert_select 'typeahead.dropdown-menu' do

try system test to count navbar typeahead results in dropdown #5525

try system test to count navbar typeahead results in dropdown #5525

Conversation

jywarren commented Apr 18, 2019

plotsbot commented Apr 18, 2019 • edited Loading

jywarren commented Apr 22, 2019

jywarren Apr 22, 2019

Choose a reason for hiding this comment

jywarren Apr 22, 2019

Choose a reason for hiding this comment

jywarren Apr 23, 2019

Choose a reason for hiding this comment

jywarren commented Apr 22, 2019

jywarren Apr 23, 2019

Choose a reason for hiding this comment

jywarren commented Apr 23, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

jywarren commented Apr 24, 2019

plotsbot commented Apr 18, 2019 •

edited

Loading