Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slic3r crashes when adding files that don't fit the bed #11

Closed
uclaros opened this issue Nov 3, 2016 · 11 comments
Closed

Slic3r crashes when adding files that don't fit the bed #11

uclaros opened this issue Nov 3, 2016 · 11 comments

Comments

@uclaros
Copy link

uclaros commented Nov 3, 2016

Version

1.31.2-prusa3d-win64

Operating system type + version

Windows7 64 sp1

Behavior

If 'Auto-center parts' is enabled, adding stl files that don't fit the build table cause a crash.
This happens both by adding one huge object or by adding many smaller ones.

STL/Config (.ZIP) where problem occurs

Any bunch of stl files that don't fit the table with 'auto-center parts' enabled.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 3, 2016

Does slic3r crash, or hang? I have seen hang ups, but not crashes.

On Thu, Nov 3, 2016 at 5:50 PM, uclaros [email protected] wrote:

Version

1.31.2-prusa3d-win64
Operating system type + version

Windows7 64 sp1
Behavior

If 'Auto-center parts' is enabled, adding stl files that don't fit the
build table cause a crash.
This happens both by adding one huge object or by adding many smaller ones.
STL/Config (.ZIP) where problem occurs

Any bunch of stl files that don't fit the table with 'auto-center parts'
enabled.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFj5I7qT53eSt8TYQd0J0X8pPuuKLg2Eks5q6hDPgaJpZM4KopJt
.

@uclaros
Copy link
Author

uclaros commented Nov 3, 2016

Call it what you will...
image

@uclaros uclaros closed this as completed Nov 3, 2016
@uclaros uclaros reopened this Nov 3, 2016
@chriszero
Copy link

This also happens with the latest slic3r prusa build. This happens really often to me.
Win10 64bit

@uclaros
Copy link
Author

uclaros commented Nov 4, 2016

Disabling "Auto-center parts" from preferences is a temporary solution.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 4, 2016

I am aware of the issue, spent about half a day with it two weeks before,
but I was not able to find the cause. Probably it has something to do with
the UI/computing core synchronization.

On Fri, Nov 4, 2016 at 11:03 AM, uclaros [email protected] wrote:

Disabling "Auto-center parts" from preferences is a temporary solution.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I6NHA_VCpZp_xAUZkt8zxd4FurDIks5q6wL4gaJpZM4KopJt
.

@uclaros
Copy link
Author

uclaros commented Nov 4, 2016

The bug did not exist in the stable version of upstream slic3r. I haven't tested the upstream/master branch yet.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 4, 2016

what do you mean with stable upstream Slic3r? 1.2.9?

On Fri, Nov 4, 2016 at 11:09 AM, uclaros [email protected] wrote:

The bug did not exist in the stable version of upstream slic3r. I haven't
tested the upstream/master branch yet.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5IzQ2IxC_CiIiO3We7E60X-__wZg2ks5q6wRugaJpZM4KopJt
.

@uclaros
Copy link
Author

uclaros commented Nov 4, 2016

Both 1.2.9 release and the upstream/stable branch, 1.2.10-dev

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 4, 2016

How about the builds by @lordofhyphens?
https://bintray.com/lordofhyphens/Slic3r/Slic3r_Branches

On Fri, Nov 4, 2016 at 11:58 AM, uclaros [email protected] wrote:

Both 1.2.9 release and the upstream/stable branch, 1.2.10-dev


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFj5I6h3twYHfWrDKvV1ReBgH5S3dN-Qks5q6w_cgaJpZM4KopJt
.

bubnikv added a commit that referenced this issue Nov 4, 2016
Replaced eval { die } construct with a bool return value indicating
success or failure of an automatic arrangement of parts on the print bed.

Don't know exactly what is happening here, but throwing a "die" inside
a XS function and then catching it inside an eval {} block is suspcious.
@bubnikv
Copy link
Collaborator

bubnikv commented Nov 4, 2016

All right, seems that following check-in fixed the hang-up.
6217622

I replaced a Perl style exception from the auto arrangement function with a boolean return value. I don't understand how the old code supposed to work, maybe it was somehow dependent on versions Perl or Wx or gcc. Whatever, I replaced the code with something straightforward and easy to follow.

Closing this issue, please feel free to reopen if it reappears.

@bubnikv bubnikv closed this as completed Nov 4, 2016
@bubnikv bubnikv mentioned this issue Nov 4, 2016
@bubnikv
Copy link
Collaborator

bubnikv commented Nov 4, 2016

Actually the problem is Windows Strawberry Perl / MINGW specific:
If a croak() is called from a C++ try/catch block, the process hangs.
https://www.nntp.perl.org/group/perl.perl5.porters/2015/01/msg225230.html

alranel pushed a commit to slic3r/Slic3r that referenced this issue Nov 24, 2016
Replaced eval { die } construct with a bool return value indicating
success or failure of an automatic arrangement of parts on the print bed.

Don't know exactly what is happening here, but throwing a "die" inside
a XS function and then catching it inside an eval {} block is suspcious.

Conflicts:

	xs/src/libslic3r/Geometry.cpp
	xs/src/libslic3r/Geometry.hpp
bubnikv pushed a commit that referenced this issue Jan 31, 2023
* import updates from curling avoidance branch

* fix compilation issues

* Refactoring FDM support spots generator to use the new Z-graph built during slicing

* fix local issues bugs

* fix bugs, add new filter for too short extrusions

* fix bugs with nonexistent weakest area

* Use links of Z graph after fix, format the code

* remove unnecesary includes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants