Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to provide WORKSPACE dependencies when protobuf is depended on in Bazel #5905

Closed
perezd opened this issue Mar 16, 2019 · 4 comments
Closed

Comments

@perezd
Copy link
Contributor

perezd commented Mar 16, 2019

I'm trying to address this issue in another repo: google/bazel-common#51
Currently I'm blocked because I'm unable to provide the necessary dependency on //external:error_prone_annotations defined in WORKSPACE here:
https://github.com/protocolbuffers/protobuf/blob/master/WORKSPACE#L74

FWIW, Bazel recommends to avoid bind:
https://docs.bazel.build/versions/master/external.html#best-practices

This is might be especially worth noting in a Google open source project.

Any suggestions on how provide that dependency from bazel-common? Ironically, we are already loading the annotations over there, I just need a way to provide them to com_google_protobuf when it builds protobuf_java_util

@ghost
Copy link

ghost commented Apr 3, 2019

Sorry for the late reply, looking into this now.

@ghost
Copy link

ghost commented Apr 3, 2019

@perezd, would you mind pointing me to a repo where I can easily reproduce this?

@perezd
Copy link
Contributor Author

perezd commented Apr 3, 2019 via email

@ghost
Copy link

ghost commented Apr 3, 2019

ok. I will close this issue, then.

@ghost ghost closed this as completed Apr 3, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant