-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to provide WORKSPACE dependencies when protobuf is depended on in Bazel #5905
Comments
This was referenced Mar 20, 2019
Sorry for the late reply, looking into this now. |
@perezd, would you mind pointing me to a repo where I can easily reproduce this? |
This may have been a misunderstanding, I found in the 3.7.x branch that
this does work as expected.
…On Wed, Apr 3, 2019 at 3:19 PM Hao Nguyen ***@***.***> wrote:
@perezd <https://github.com/perezd>, would you mind pointing me to a repo
where I can easily reproduce this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5905 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABQdvAty9SS19kpobLlOl7GriSUa66Qks5vdSj3gaJpZM4b365i>
.
|
ok. I will close this issue, then. |
ghost
closed this as completed
Apr 3, 2019
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to address this issue in another repo: google/bazel-common#51
Currently I'm blocked because I'm unable to provide the necessary dependency on
//external:error_prone_annotations
defined in WORKSPACE here:https://github.com/protocolbuffers/protobuf/blob/master/WORKSPACE#L74
FWIW, Bazel recommends to avoid bind:
https://docs.bazel.build/versions/master/external.html#best-practices
This is might be especially worth noting in a Google open source project.
Any suggestions on how provide that dependency from bazel-common? Ironically, we are already loading the annotations over there, I just need a way to provide them to com_google_protobuf when it builds
protobuf_java_util
The text was updated successfully, but these errors were encountered: