Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.7.0 release fails to build with bazel due to missing error prone dependency #5795

Closed
apilloud opened this issue Feb 28, 2019 · 3 comments
Closed
Assignees
Labels

Comments

@apilloud
Copy link

apilloud commented Feb 28, 2019

What version of protobuf and what language are you using?
Version: 3.7.0
Language: Java

What operating system (Linux, Windows, ...) and version?

Debian based linux.

What runtime / compiler are you using (e.g., python version or gcc version)

What did you do?
bazel build //:protobuf_java_util

What did you expect to see
Build completed successfully

What did you see instead?

$ bazel build //:protobuf_java_util
Starting local Bazel server and connecting to it...
INFO: Analysed target //:protobuf_java_util (16 packages loaded, 961 targets configured).
INFO: Found 1 target...
ERROR: /home/apilloud/protobuf-3.7.0/BUILD:632:1: Building libprotobuf_java_util.jar (6 source files) failed (Exit 1)
java/util/src/main/java/com/google/protobuf/util/Timestamps.java:39: error: package com.google.errorprone.annotations does not exist
import com.google.errorprone.annotations.CanIgnoreReturnValue;
                                        ^
java/util/src/main/java/com/google/protobuf/util/Durations.java:45: error: package com.google.errorprone.annotations does not exist
import com.google.errorprone.annotations.CanIgnoreReturnValue;
                                        ^
java/util/src/main/java/com/google/protobuf/util/FieldMaskTree.java:33: error: package com.google.errorprone.annotations does not exist
import com.google.errorprone.annotations.CanIgnoreReturnValue;
                                        ^
java/util/src/main/java/com/google/protobuf/util/FieldMaskUtil.java:39: error: package com.google.errorprone.annotations does not exist
import com.google.errorprone.annotations.CanIgnoreReturnValue;
                                        ^
java/util/src/main/java/com/google/protobuf/util/JsonFormat.java:35: error: package com.google.errorprone.annotations does not exist
import com.google.errorprone.annotations.CanIgnoreReturnValue;
                                        ^
java/util/src/main/java/com/google/protobuf/util/Durations.java:155: error: cannot find symbol
  @CanIgnoreReturnValue
   ^
  symbol:   class CanIgnoreReturnValue
  location: class Durations
java/util/src/main/java/com/google/protobuf/util/Durations.java:168: error: cannot find symbol
  @CanIgnoreReturnValue
   ^
  symbol:   class CanIgnoreReturnValue
  location: class Durations
java/util/src/main/java/com/google/protobuf/util/Durations.java:179: error: cannot find symbol
  @CanIgnoreReturnValue
   ^
  symbol:   class CanIgnoreReturnValue
  location: class Durations
java/util/src/main/java/com/google/protobuf/util/Timestamps.java:166: error: cannot find symbol
  @CanIgnoreReturnValue
   ^
  symbol:   class CanIgnoreReturnValue
  location: class Timestamps
java/util/src/main/java/com/google/protobuf/util/FieldMaskTree.java:99: error: cannot find symbol
  @CanIgnoreReturnValue
   ^
  symbol:   class CanIgnoreReturnValue
  location: class FieldMaskTree
java/util/src/main/java/com/google/protobuf/util/FieldMaskTree.java:129: error: cannot find symbol
  @CanIgnoreReturnValue
   ^
  symbol:   class CanIgnoreReturnValue
  location: class FieldMaskTree
java/util/src/main/java/com/google/protobuf/util/FieldMaskUtil.java:310: error: cannot find symbol
    @CanIgnoreReturnValue
     ^
  symbol:   class CanIgnoreReturnValue
  location: class MergeOptions
java/util/src/main/java/com/google/protobuf/util/FieldMaskUtil.java:323: error: cannot find symbol
    @CanIgnoreReturnValue
     ^
  symbol:   class CanIgnoreReturnValue
  location: class MergeOptions
java/util/src/main/java/com/google/protobuf/util/FieldMaskUtil.java:340: error: cannot find symbol
    @CanIgnoreReturnValue
     ^
  symbol:   class CanIgnoreReturnValue
  location: class MergeOptions
java/util/src/main/java/com/google/protobuf/util/JsonFormat.java:474: error: cannot find symbol
      @CanIgnoreReturnValue
       ^
  symbol:   class CanIgnoreReturnValue
  location: class Builder
java/util/src/main/java/com/google/protobuf/util/JsonFormat.java:487: error: cannot find symbol
      @CanIgnoreReturnValue
       ^
  symbol:   class CanIgnoreReturnValue
  location: class Builder
Target //:protobuf_java_util failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 45.120s, Critical Path: 19.88s
INFO: 183 processes: 182 linux-sandbox, 1 worker.
FAILED: Build did NOT complete successfully

Anything else we should know about your project / environment

davido added a commit to davido/protobuf that referenced this issue Mar 3, 2019
Recently dependency to error_prone_annotations was added to the code,
but only Maven build tool chain was updated.

Closes protocolbuffers#5795.
@TeBoring TeBoring added this to the v3.7.0 milestone Mar 4, 2019
@TeBoring TeBoring added the bazel label Mar 4, 2019
acozzette pushed a commit that referenced this issue Mar 8, 2019
Recently dependency to error_prone_annotations was added to the code,
but only Maven build tool chain was updated.

Closes #5795.
davido added a commit to davido/protobuf that referenced this issue Mar 8, 2019
Recently dependency to error_prone_annotations was added to the code,
but only Maven build tool chain was updated.

Closes protocolbuffers#5795.
acozzette pushed a commit that referenced this issue Mar 8, 2019
Recently dependency to error_prone_annotations was added to the code,
but only Maven build tool chain was updated.

Closes #5795.
@perezd
Copy link
Contributor

perezd commented Mar 20, 2019

This change has made it impossible for other Bazel projects to depend on this repository and provide the necessary binding to errorprone, see: #5905

@TeBoring
Copy link
Contributor

@perezd Are you talking about something has been fixed in 3.7.x branch (but haven't released)?

@perezd
Copy link
Contributor

perezd commented Mar 20, 2019

Derp, yes in fact I am. I didn't catch that this was not in 3.7.0. OK, any idea when that would be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants
@perezd @acozzette @TeBoring @apilloud and others