-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf should be updated to 3.7.0 #51
Comments
Current workaround for a .bazelrc:
|
I've also been waiting for that. But I just checked the diff, and I'm not seeing much that actually changed functionally, and I think I'd be willing to upgrade the bazel rules on their own unless they're comfortable making a Maven release soon |
Yeah I pinged the thread, let's see what they say.
…On Fri, Jan 18, 2019, 10:09 AM Ron Shapiro ***@***.***> wrote:
I've also been waiting for that. But I just checked the diff, and I'm not
seeing much that actually changed functionally, and I think I'd be willing
to upgrade the bazel rules on their own unless they're comfortable making a
Maven release soon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABQdiQxxqBzPzkSKD0ZSjynu5hUiOGiks5vEg3kgaJpZM4aIYBa>
.
|
OK so with Bazel 0.22 released officially this is now a fatal error. Codebase no longer compiles and the workaround flag is gone. What should we do? |
Someone was too happy to deprecate that. For now, we could compile the binaries by ourselves (like with grpc-java) instead of using maven's. |
Any update here? |
https://search.maven.org/artifact/com.google.protobuf/protobuf-java/3.7.0/bundle 3.7.0 is now available @ Maven which has this patch. |
I'm taking a stab at this upgrade but its blocked by the bug referenced above. |
Turns out there are more bazel deprecations:
protocolbuffers/protobuf#5547
One thing I noticed is the maven jar is 3.6.1 (released july) and 3.6.1.3 (released december) doesn't have a protobuf_java corollary. I asked them to cut one but I assume that would block adoption here?
The text was updated successfully, but these errors were encountered: