Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf should be updated to 3.7.0 #51

Closed
perezd opened this issue Jan 18, 2019 · 8 comments
Closed

Protobuf should be updated to 3.7.0 #51

perezd opened this issue Jan 18, 2019 · 8 comments

Comments

@perezd
Copy link
Contributor

perezd commented Jan 18, 2019

Turns out there are more bazel deprecations:
protocolbuffers/protobuf#5547

One thing I noticed is the maven jar is 3.6.1 (released july) and 3.6.1.3 (released december) doesn't have a protobuf_java corollary. I asked them to cut one but I assume that would block adoption here?

@perezd
Copy link
Contributor Author

perezd commented Jan 18, 2019

Current workaround for a .bazelrc:

build --incompatible_package_name_is_a_function=false

@ronshapiro
Copy link
Contributor

I've also been waiting for that. But I just checked the diff, and I'm not seeing much that actually changed functionally, and I think I'd be willing to upgrade the bazel rules on their own unless they're comfortable making a Maven release soon

@perezd
Copy link
Contributor Author

perezd commented Jan 18, 2019 via email

@perezd
Copy link
Contributor Author

perezd commented Jan 29, 2019

OK so with Bazel 0.22 released officially this is now a fatal error. Codebase no longer compiles and the workaround flag is gone. What should we do?

@Reflexe
Copy link

Reflexe commented Feb 4, 2019

Someone was too happy to deprecate that. For now, we could compile the binaries by ourselves (like with grpc-java) instead of using maven's.

@perezd
Copy link
Contributor Author

perezd commented Mar 6, 2019

Any update here?

@perezd
Copy link
Contributor Author

perezd commented Mar 13, 2019

https://search.maven.org/artifact/com.google.protobuf/protobuf-java/3.7.0/bundle

3.7.0 is now available @ Maven which has this patch.

@perezd perezd changed the title Protobuf should be updated to 3.6.1.3 Protobuf should be updated to 3.7.0 Mar 16, 2019
@perezd
Copy link
Contributor Author

perezd commented Mar 16, 2019

I'm taking a stab at this upgrade but its blocked by the bug referenced above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants