Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf-3.6.1 doesn't build :protobuf with latest bazel (0.21.0) #5547

Closed
unrstuart opened this issue Jan 7, 2019 · 8 comments
Closed

protobuf-3.6.1 doesn't build :protobuf with latest bazel (0.21.0) #5547

unrstuart opened this issue Jan 7, 2019 · 8 comments
Assignees
Labels
bazel inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@unrstuart
Copy link

unrstuart commented Jan 7, 2019

3.6.1 - language agnostic, this is a build error
Linux amd64

Below is the error I see. If I change REPOSITORY_NAME to repository_name(), it then breaks again = )

Specifying the bazel flag allows the build to succeed, but one shouldn't have to do that. bazel build -c opt :protobuf should just work.

cpunerd@cpunerd:~/src/protobuf-3.6.1$ bazel build -c opt :protobuf
INFO: Invocation ID: 9f581ef9-5569-4cab-8de7-4e6b98b5b728
ERROR: /usr/local/google/home/cpunerd/src/protobuf-3.6.1/BUILD:573:1: Traceback (most recent call last):
	File "/usr/local/google/home/cpunerd/src/protobuf-3.6.1/BUILD", line 573
		internal_gen_well_known_protos_java(srcs = WELL_KNOWN_PROTOS)
	File "/usr/local/google/home/cpunerd/src/protobuf-3.6.1/protobuf.bzl", line 269, in internal_gen_well_known_protos_java
		Label(("%s//protobuf_java" % REPOSITOR...))
	File "/usr/local/google/home/cpunerd/src/protobuf-3.6.1/protobuf.bzl", line 269, in Label
		REPOSITORY_NAME
The value 'REPOSITORY_NAME' has been removed in favor of 'repository_name()', please use the latter (https://docs.bazel.build/versions/master/skylark/lib/native.html#repository_name). You can temporarily allow the old name by using --incompatible_package_name_is_a_function=false
ERROR: error loading package '': Package '' contains errors
INFO: Elapsed time: 0.148s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
cpunerd@cpunerd:~/src/protobuf-3.6.1$ vim protobuf.bzl 
cpunerd@cpunerd:~/src/protobuf-3.6.1$ bazel build -c opt :protobuf
INFO: Invocation ID: 51c58852-f4ed-4078-9dad-83ae1474fabc
ERROR: /usr/local/google/home/cpunerd/src/protobuf-3.6.1/protobuf.bzl:269:39: name 'repository_name' is not defined (did you mean 'REPOSITORY_NAME'?)
ERROR: Skipping ':protobuf': error loading package '': Extension 'protobuf.bzl' has errors
WARNING: Target pattern parsing failed.
ERROR: error loading package '': Extension 'protobuf.bzl' has errors
INFO: Elapsed time: 0.168s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
    currently loading: 
cpunerd@cpunerd:~/src/protobuf-3.6.1$ 
@unrstuart
Copy link
Author

(apologies for the strikethrough, must've been some MD formatting i wasn't aware of)

@redshirtrob
Copy link

You may want to have a look at #5418 and #5490. Looks like fixes are pending.

@jtattermusch
Copy link
Contributor

I believe the latest release tag https://github.com/protocolbuffers/protobuf/releases/tag/v3.6.1.3 has all the fixes you need.

@unrstuart
Copy link
Author

unrstuart commented Jan 16, 2019 via email

@perezd
Copy link
Contributor

perezd commented Jan 18, 2019

It seems like maven doesn't have an instance of v3.6.1.3 for protobuf-java that corresponds, can that be addressed? https://search.maven.org/search?q=g:com.google.protobuf

@perezd
Copy link
Contributor

perezd commented Jan 29, 2019

With Bazel 0.22 This error is now a major show stopper (unable to compile, full stop error), a corresponding jar distribution would be ideal to coincide with v3.6.1.3 tag.

Here's the corresponding deprecation bug w/ Bazel:
bazelbuild/bazel#5827

Copy link

github-actions bot commented May 5, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label May 5, 2024
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please reopen it.

This issue was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Development

No branches or pull requests

6 participants