-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert circleci config to 2.0. #844
Conversation
Cool, I was waiting for the first one to move to ask "can you do that on all repos please" :D |
@grobie hah! Yea, there's a bunch of stuff that's easier in 2.0 configs. But, as you can see, it's not working perfectly yet with |
Nice, I was going to look at this. |
@sdurrheimer promu crossbuild failed, not sure why. |
@SuperQ Can you add a |
cd3f175
to
f424f7b
Compare
@grobie @matthiasr The test and build workflow steps now work reliably. The publish steps should work now as well, but we need to try cutting an actual release from master to test them end-to-end. |
Let's cut an 0.16 beta then? |
@matthiasr Yup, that's the plan, I want to cut it as rc0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
So this config uses a lot more hardcoded names now, where we previously used template variables. This makes it a lot more cumbersome to keep our circle CI configs in sync between projects. Can you bring back the environment variables to reference the repo+organization names? |
@grobie Based on the documentation I've read so far, the |
No description provided.