Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CircleCI configuration to 2.0 format #148

Closed
beorn7 opened this issue Mar 8, 2018 · 2 comments
Closed

Update CircleCI configuration to 2.0 format #148

beorn7 opened this issue Mar 8, 2018 · 2 comments
Labels
enhancement good first issue help wanted

Comments

@beorn7
Copy link
Member

beorn7 commented Mar 8, 2018

CircleCI 1.0 will be shut down on August 31. Resources

Template to work off: prometheus/node_exporter#844
@hairyhenderson
Copy link
Contributor

I was about to take this on, but then realized that CircleCI builds seem not to run during forked PRs. Can this be enabled? There's a separate setting in CircleCI for passing secrets to forked builds, so I think there shouldn't be a security issue.

@hairyhenderson hairyhenderson mentioned this issue Mar 25, 2018
Closed
@beorn7
Copy link
Member Author

beorn7 commented Mar 26, 2018

Thanks for pointing that out. I have enabled builds for PRs from forks now.

@SuperQ SuperQ mentioned this issue May 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hairyhenderson @beorn7