test/e2e/gateway: Remove redundant tests #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covered by conformance tests for exact path matching and prefix path matching Still need to contribute a couple prefix match cases back upstream before we can delete this test completely Signed-off-by: Sunjay Bhatia <[email protected]>
Covered in Gateway API v0.6.0 More advanced features are not covered in the latest release but are on main, so we cannot remove those cases yet. Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
added
the
release-note/none-required
sunjayBhatia
requested review from
tsaarni,
stevesloka and
skriss
and removed request for
a team
|
See kubernetes-sigs/gateway-api#1627 for PR to gw api main to add more path matching cases |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4961 +/- ##
=======================================
Coverage 76.50% 76.50%
=======================================
Files 140 140
Lines 16772 16772
=======================================
Hits 12832 12832
Misses 3690 3690
Partials 250 250 |
skriss
approved these changes
Jan 11, 2023
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Remove test cases for path matching Covered by conformance tests for exact path matching and prefix path matching Remove basic path redirect test Covered in Gateway API v0.6.0 More advanced features are not covered in the latest release but are on main, so we cannot remove those cases yet. Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Remove test cases for path matching Covered by conformance tests for exact path matching and prefix path matching Remove basic path redirect test Covered in Gateway API v0.6.0 More advanced features are not covered in the latest release but are on main, so we cannot remove those cases yet. Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
Remove test cases for path matching Covered by conformance tests for exact path matching and prefix path matching Remove basic path redirect test Covered in Gateway API v0.6.0 More advanced features are not covered in the latest release but are on main, so we cannot remove those cases yet. Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Updates #4579