Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Contour E2E's that overlap with Gateway API conformance #4579

Closed
skriss opened this issue Jun 14, 2022 · 9 comments
Closed

remove Contour E2E's that overlap with Gateway API conformance #4579

skriss opened this issue Jun 14, 2022 · 9 comments
Assignees
@sunjayBhatia
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
1.27.0

Comments

@skriss
Copy link
Member

skriss commented Jun 14, 2022

As upstream Gateway API conformance tests are built out, we can probably get rid of overlapping Contour E2E's that validate the same functionality. This will save some CI time and reduce maintenance burden. As a starting point, once we upgrade to Gateway API v0.5.0 and pin to the conformance tests included there, we should do an audit of Contour's E2E's and drop any redundant ones.
@skriss skriss added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jun 14, 2022
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.
This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied - After 30d of inactivity since lifecycle/stale was applied, the Issue is closed
    You can:
  • Mark this Issue as fresh by commenting - Close this Issue - Offer to help out with triage
    Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2022
@sunjayBhatia
Copy link
Member

unstaling, this seems worthwhile to do

@sunjayBhatia sunjayBhatia added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 28, 2022
@sunjayBhatia sunjayBhatia mentioned this issue Sep 29, 2022
Merged
@sunjayBhatia
Copy link
Member

some removals going in here: #4765

@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Oct 3, 2022
@skriss skriss moved this to In Progress in Contour Oct 3, 2022
@skriss
Copy link
Member Author

skriss commented Oct 3, 2022

Adding this to the current milestone for tracking, we'll likely carry it forward.

@skriss skriss added this to the 1.23.0 milestone Oct 3, 2022
@skriss
Copy link
Member Author

skriss commented Oct 13, 2022

Bumping to 1.24.0 for continued work.

@skriss skriss modified the milestones: 1.23.0, 1.24.0 Oct 13, 2022
@sunjayBhatia sunjayBhatia mentioned this issue Jan 5, 2023
Merged
@skriss
Copy link
Member Author

skriss commented Jan 19, 2023

@sunjayBhatia anything else here for 1.24, or shall we move this over to 1.25 for continued work?

@sunjayBhatia
Copy link
Member

I'll take another pass over the 0.6.0 tests to see if there's any overlap, but i think safe to move to the next release since theres a lot left

@skriss skriss modified the milestones: 1.24.0, 1.25.0 Jan 19, 2023
skriss pushed a commit that referenced this issue Feb 13, 2023
@sunjayBhatia
test/e2e/gateway: Remove more duplicate tests (#5087)
3b486b7 
* test/e2e/gateway: Remove path condition match test

Duplicate of test added in
kubernetes-sigs/gateway-api@be595a2

* test/e2e/gateway: Remove TLSRoute test

Covered by test added in
kubernetes-sigs/gateway-api@a201494

Updates #4579.

Signed-off-by: Sunjay Bhatia <[email protected]>
yangyy93 pushed a commit to projectsesame/contour that referenced this issue Feb 16, 2023
@sunjayBhatia @yangyy93
test/e2e/gateway: Remove more duplicate tests (projectcontour#5087)
abb329a 
* test/e2e/gateway: Remove path condition match test

Duplicate of test added in
kubernetes-sigs/gateway-api@be595a2

* test/e2e/gateway: Remove TLSRoute test

Covered by test added in
kubernetes-sigs/gateway-api@a201494

Updates projectcontour#4579.

Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: yy <[email protected]>
yangyy93 pushed a commit to projectsesame/contour that referenced this issue Feb 16, 2023
@sunjayBhatia @yangyy93
test/e2e/gateway: Remove more duplicate tests (projectcontour#5087)
7c8df9e 
* test/e2e/gateway: Remove path condition match test

Duplicate of test added in
kubernetes-sigs/gateway-api@be595a2

* test/e2e/gateway: Remove TLSRoute test

Covered by test added in
kubernetes-sigs/gateway-api@a201494

Updates projectcontour#4579.

Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: yy <[email protected]>
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this issue Feb 28, 2023
@sunjayBhatia @vmw-yingy
test/e2e/gateway: Remove more duplicate tests (projectcontour#5087)
abf63b4 
* test/e2e/gateway: Remove path condition match test

Duplicate of test added in
kubernetes-sigs/gateway-api@be595a2

* test/e2e/gateway: Remove TLSRoute test

Covered by test added in
kubernetes-sigs/gateway-api@a201494

Updates projectcontour#4579.

Signed-off-by: Sunjay Bhatia <[email protected]>
skriss added a commit to skriss/contour that referenced this issue Mar 22, 2023
@skriss
test/e2e: drop redundant provisioner tests
7627efa 
Covered by Gateway API conformance tests.

Updates projectcontour#4579.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss mentioned this issue Mar 22, 2023
Merged
skriss added a commit that referenced this issue Mar 22, 2023
@skriss
test/e2e: drop redundant provisioner tests (#5215)
7c3bd5c 
Covered by Gateway API conformance tests.

Updates #4579.

Signed-off-by: Steve Kriss <[email protected]>
yangyy93 pushed a commit to projectsesame/contour that referenced this issue Mar 27, 2023
@skriss @yangyy93
test/e2e: drop redundant provisioner tests (projectcontour#5215)
274abdf 
Covered by Gateway API conformance tests.

Updates projectcontour#4579.

Signed-off-by: Steve Kriss <[email protected]>
yangyy93 pushed a commit to projectsesame/contour that referenced this issue Mar 27, 2023
@skriss @yangyy93
test/e2e: drop redundant provisioner tests (projectcontour#5215)
5bca0a1 
Covered by Gateway API conformance tests.

Updates projectcontour#4579.

Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: yy <[email protected]>
@skriss skriss modified the milestones: 1.25.0, 1.26.0 Apr 26, 2023
@sunjayBhatia
Copy link
Member

looks like none of the gateway tests are removable due to overlap with v0.7.1 or v0.8.0-rc1 tags as far as I can tell, can call this done for v1.26.0 IMO

@sunjayBhatia sunjayBhatia modified the milestones: 1.26.0, 1.27.0 Aug 9, 2023
@skriss
Copy link
Member Author

skriss commented Oct 9, 2023

I'm going to close this out as we've done most/all of this work by now. Can file specific issues as anything else comes up.

@skriss skriss closed this as completed Oct 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Contour Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunjayBhatia sunjayBhatia

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Contour
Status: Done
Milestone
1.27.0
Development

No branches or pull requests
2 participants
@skriss @sunjayBhatia