conformance: Add additional path matching edge cases #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- trailing slash on path prefix should match - path prefixes are path segment matches not string prefix matches - test to ensure a path containing the prefix is not matched Signed-off-by: Sunjay Bhatia <[email protected]>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/S
skriss
approved these changes
Jan 6, 2023
|
Great additions, thanks @sunjayBhatia! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, skriss, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shaneutt
pushed a commit
that referenced
this pull request
Feb 7, 2023
…h-matching-cases conformance: Add additional path matching edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds some test cases (from Contour e2e tests) for edge cases in path matching.
In consolidating this set of test cases: https://github.com/projectcontour/contour/blob/76521b7dbc562815083ec207abef686bc02614ce/test/e2e/gateway/path_condition_match_test.go#L69-L84
We found we can eliminate all but a few that do not have overlap with the upstream conformance tests, so added tests for the following cases:
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: