-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo android python PR #8940
Merged
Merged
Redo android python PR #8940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion outside of Github CI This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928. Using this revert to figure out what breaks CI
Damian-Nordic
approved these changes
Aug 12, 2021
saurabhst
approved these changes
Aug 12, 2021
pullapprove
bot
requested review from
austinh0,
chrisdecenzo,
jelderton,
jmartinez-silabs,
mspang and
woody-apple
August 12, 2021 14:49
bzbarsky-apple
approved these changes
Aug 12, 2021
Restyler fails because I changed a .workflow yaml. |
Size increase report for "esp32-example-build" from f031500
Full report output
|
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Re-make Compile android in build_examples.py and move android compilation outside of Github CI This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928. Using this revert to figure out what breaks CI * Noop change to trigger build actions for testing * Ensure ENTIRE environment (including e.g. PATH) is forwarded to the test script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Android PR was reverted due to unit test failures.
Cause seems to be that the 'run subprocess with env' is actually a 'CLEAR env and add these properties' and the clear kills our python settings, hence 'python3 not found' or 'coloredlogs module not found' etc.
Change overview
Same PR as #8862, except python fixes: clone os.environ in the run environment of the subprocess.
Testing
Github CI passes (rest of functionality was tested in original PR)