Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo android python PR #8940

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Aug 12, 2021

Problem

Android PR was reverted due to unit test failures.

Cause seems to be that the 'run subprocess with env' is actually a 'CLEAR env and add these properties' and the clear kills our python settings, hence 'python3 not found' or 'coloredlogs module not found' etc.

Change overview

Same PR as #8862, except python fixes: clone os.environ in the run environment of the subprocess.

Testing

Github CI passes (rest of functionality was tested in original PR)

…tion outside of Github CI

This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928.

Using this revert to figure out what breaks CI
@andy31415
Copy link
Contributor Author

Restyler fails because I changed a .workflow yaml.
I will ignore the restyler error for this PR (I ran restyle manually)

@github-actions
Copy link

Size increase report for "esp32-example-build" from f031500

File Section File VM
chip-shell.elf .flash.text -8 -8
chip-bridge-app.elf .flash.text 48 48
chip-lock-app.elf .flash.text -68 -68
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,8
.flash.text,-8,-8

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.flash.text,48,48
[Unmapped],0,-48

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,68
.flash.text,-68,-68

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit 6a0c11d into project-chip:master Aug 12, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* Re-make Compile android in build_examples.py and move android compilation outside of Github CI

This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928.

Using this revert to figure out what breaks CI

* Noop change to trigger build actions for testing

* Ensure ENTIRE environment (including e.g. PATH) is forwarded to the test script
@andy31415 andy31415 deleted the redo_android_python branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants