Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Compile android in build_examples.py and move android compilation outside of Github CI" #8928

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

woody-apple
Copy link
Contributor

Reverts #8862

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label Aug 12, 2021
@woody-apple woody-apple merged commit 0b406de into master Aug 12, 2021
@woody-apple woody-apple deleted the revert-8862-android_example_build_py branch August 12, 2021 04:28
@github-actions
Copy link

Size increase report for "esp32-example-build" from 50d80b9

File Section File VM
chip-temperature-measurement-app.elf .flash.text 60 60
chip-shell.elf .flash.text 8 8
chip-ipv6only-app.elf .flash.text -172 -172
chip-bridge-app.elf .flash.text -48 -48
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,8,8
[Unmapped],0,-8

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,172
.flash.text,-172,-172

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
[Unmapped],0,48
.flash.text,-48,-48


andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Aug 12, 2021
…tion outside of Github CI

This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928.

Using this revert to figure out what breaks CI
andy31415 added a commit that referenced this pull request Aug 12, 2021
* Re-make Compile android in build_examples.py and move android compilation outside of Github CI

This is a revert of #8862 which in turn reverts the original #8928.

Using this revert to figure out what breaks CI

* Noop change to trigger build actions for testing

* Ensure ENTIRE environment (including e.g. PATH) is forwarded to the test script
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* Re-make Compile android in build_examples.py and move android compilation outside of Github CI

This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928.

Using this revert to figure out what breaks CI

* Noop change to trigger build actions for testing

* Ensure ENTIRE environment (including e.g. PATH) is forwarded to the test script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android github hotfix urgent fix needed, can bypass review scripts workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant