-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile android in build_examples.py and move android compilation outside of Github CI #8862
Compile android in build_examples.py and move android compilation outside of Github CI #8862
Conversation
…accepted at build time
vscode does not seem to allow license accepting. This will only pass after #8864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use directory listings in build scripts.
(very few build systems delete files, they only replace them. Doing this invariably leads to broken outputs and confused engineers) |
Size increase report for "gn_qpg-example-build" from 2ee1e70
Full report output
|
Size increase report for "esp32-example-build" from 2ee1e70
Full report output
|
Updated to not use rsync/path walk equivalents. |
Ok, that's broken, and is exactly the kind of unfortunate issue that globbing causes. |
…tion outside of Github CI This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928. Using this revert to figure out what breaks CI
* Re-make Compile android in build_examples.py and move android compilation outside of Github CI This is a revert of #8862 which in turn reverts the original #8928. Using this revert to figure out what breaks CI * Noop change to trigger build actions for testing * Ensure ENTIRE environment (including e.g. PATH) is forwarded to the test script
…side of Github CI (project-chip#8862) * Starting to build android: native library seems to build * Validate that sdkmanager is executable, then ensure ndk licenses are accepted at build time * Compiling the apk now works (no jni so copying yet though) * Restyle fixes * Apk build now includes .so files for jni * PyFormat * Another pyformat on factory/targets * Move android to workflow_dispatch * Fix unit tests, pyformat android and test.py * Update error text for writable check on android home licenses * Accept the possibility that the android licenses folder does not exist at all * Update to _build and build_outputs method naming for android * Do not use rsync and instead do explicit path updates for android native libraries * Remove obsolete code for output calculation * Update GH Actions to use the updated examples build script * Fix android build examples command line - script to be executed must be a string apparently
…tion outside of Github CI (project-chip#8862)" (project-chip#8928) This reverts commit 50d80b9.
* Re-make Compile android in build_examples.py and move android compilation outside of Github CI This is a revert of project-chip#8862 which in turn reverts the original project-chip#8928. Using this revert to figure out what breaks CI * Noop change to trigger build actions for testing * Ensure ENTIRE environment (including e.g. PATH) is forwarded to the test script
Problem
Android chiptool example is not built by build_examples.py
Change overview
Add android libraries and App support in build_examples.py
Disable Github Action for 'android.yaml' and leave it to run in GCP only
Testing
Ran compilation manually in vscode environment
Unit test
GCP CI will run this.