-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup PASE code, error handling and error logging #6852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
May 15, 2021 20:04
Size increase report for "esp32-example-build" from 8a51de2
Full report output
|
Size increase report for "nrfconnect-example-build" from 8a51de2
Full report output
|
jelderton
approved these changes
May 17, 2021
woody-apple
approved these changes
May 17, 2021
msandstedt
approved these changes
May 17, 2021
saurabhst
approved these changes
May 17, 2021
woody-apple
added a commit
that referenced
this pull request
May 17, 2021
This reverts commit 8710e6b.
woody-apple
added a commit
that referenced
this pull request
May 17, 2021
pan-apple
added a commit
to pan-apple/connectedhomeip
that referenced
this pull request
May 17, 2021
…ct-chip#6852)"" This reverts commit 6bfdd05.
pan-apple
added a commit
to pan-apple/connectedhomeip
that referenced
this pull request
May 18, 2021
…ct-chip#6852)"" This reverts commit 6bfdd05.
pan-apple
added a commit
to pan-apple/connectedhomeip
that referenced
this pull request
May 24, 2021
…ct-chip#6852)"" This reverts commit 6bfdd05.
bzbarsky-apple
pushed a commit
that referenced
this pull request
May 25, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ct-chip#6852)"" (project-chip#6907) * Resurrect "Cleanup PASE code, error handling and error logging (project-chip#6852)"" This reverts commit 6bfdd05. * cleanup code * Address review comments * fix error check * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PASE Session code can use some cleanup in lieu of error handling, and error logging. For example,
Clear()
is getting called at too many places, and can be consolidated. Also, logging is usingBle
tag, which would be incorrect when PASE is used for non BLE provisioning.Summary of Changes
Code cleanup, better error handling and logging.