Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PASE code, error handling and error logging #6852

Merged
merged 1 commit into from
May 17, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

PASE Session code can use some cleanup in lieu of error handling, and error logging. For example, Clear() is getting called at too many places, and can be consolidated. Also, logging is using Ble tag, which would be incorrect when PASE is used for non BLE provisioning.

Summary of Changes

Code cleanup, better error handling and logging.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 8a51de2

File Section File VM
chip-all-clusters-app.elf .flash.rodata 104 104
chip-all-clusters-app.elf .flash.text 44 44
chip-pigweed-app.elf .flash.rodata 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,1529
.debug_loc,0,335
.strtab,0,203
.debug_str,0,185
.flash.rodata,104,104
.debug_ranges,0,56
.flash.text,44,44
.debug_frame,0,24
.debug_abbrev,0,20
.symtab,0,16
.debug_line,0,10
.debug_aranges,0,8
.shstrtab,0,1
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,1
[Unmapped],0,-104

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize
.debug_str,0,32
.debug_info,0,18
.flash.rodata,8,8
.debug_loc,0,6
[Unmapped],0,-8


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 8a51de2

File Section File VM
chip-shell.elf rodata 8 8
chip-lighting.elf rodata 104 104
chip-lighting.elf text 76 76
chip-lighting.elf device_handles 4 4
chip-lock.elf rodata 104 104
chip-lock.elf text 76 76
chip-lock.elf device_handles 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,366
.debug_str,0,32
rodata,8,8
.debug_line,0,2
.debug_loc,0,-16

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,1324
.debug_loc,0,531
.debug_str,0,185
.strtab,0,153
rodata,104,104
.symtab,0,96
text,76,76
.debug_abbrev,0,33
.debug_ranges,0,24
.debug_aranges,0,8
.debug_frame,0,4
device_handles,4,4
.shstrtab,0,-1
.debug_line,0,-53

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,1311
.debug_loc,0,539
.debug_str,0,185
.strtab,0,153
rodata,104,104
.symtab,0,96
text,76,76
.debug_abbrev,0,33
.debug_ranges,0,24
.debug_aranges,0,8
.debug_frame,0,4
device_handles,4,4
.shstrtab,0,-1
.debug_line,0,-48


@woody-apple
Copy link
Contributor

@woody-apple woody-apple merged commit 8710e6b into project-chip:master May 17, 2021
@pan-apple pan-apple deleted the pase-cleanup branch May 17, 2021 17:53
woody-apple added a commit that referenced this pull request May 17, 2021
pan-apple added a commit to pan-apple/connectedhomeip that referenced this pull request May 17, 2021
pan-apple added a commit to pan-apple/connectedhomeip that referenced this pull request May 18, 2021
pan-apple added a commit to pan-apple/connectedhomeip that referenced this pull request May 24, 2021
bzbarsky-apple pushed a commit that referenced this pull request May 25, 2021
…"" (#6907)

* Resurrect "Cleanup PASE code, error handling and error logging (#6852)""

This reverts commit 6bfdd05.

* cleanup code

* Address review comments

* fix error check

* address review comments
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…ct-chip#6852)"" (project-chip#6907)

* Resurrect "Cleanup PASE code, error handling and error logging (project-chip#6852)""

This reverts commit 6bfdd05.

* cleanup code

* Address review comments

* fix error check

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants