Resurrect "Cleanup PASE code, error handling and error logging (#6852)""

[pan-apple]

Problem

The PR #6852 was causing build issues for QPG6100. This PR tries to fix the error and resurrect the change.

Summary of Changes

Fix the issues caused by the reverted PR.

Testing

TestPASESession unit test suite
Manual testing using Python controller app
Manual testing using iOS CHIPTool app
CI runs Darwin tests that exercise the PASE Session setup process.

[github-actions]

Size increase report for "gn_qpg6100-example-build" from 1a21a3f

File	Section	File	VM
chip-qpg6100-lighting-example.out	.text	184	184

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,1344
.debug_loc,0,580
.debug_str,0,223
.strtab,0,192
.text,184,184
.symtab,0,112
.debug_ranges,0,88
.debug_abbrev,0,39
.debug_frame,0,32
.debug_aranges,0,16
.debug_line,0,14
[Unmapped],0,-184

[github-actions]

Size increase report for "nrfconnect-example-build" from 1a21a3f

File	Section	File	VM
chip-shell.elf	rodata	0	4
chip-lock.elf	rodata	104	104
chip-lock.elf	text	72	72
chip-lock.elf	device_handles	-8	-8

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,366
.debug_loc,0,32
.debug_str,0,32
rodata,4,0
.debug_line,0,2

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,1421
.debug_loc,0,536
.debug_str,0,224
.strtab,0,192
.symtab,0,112
rodata,104,104
text,72,72
.debug_abbrev,0,33
.debug_frame,0,32
.debug_ranges,0,24
.debug_aranges,0,16
device_handles,-8,-8
.debug_line,0,-22

[github-actions]

Size increase report for "esp32-example-build" from 1a21a3f

File	Section	File	VM
chip-all-clusters-app.elf	.flash.rodata	112	112
chip-all-clusters-app.elf	.flash.text	88	88
chip-pigweed-app.elf	.flash.rodata	8	8

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,1642
.debug_loc,0,394
.strtab,0,242
.debug_str,0,224
.flash.rodata,112,112
.flash.text,88,88
.debug_frame,0,48
.debug_abbrev,0,36
.symtab,0,32
.debug_aranges,0,16
.shstrtab,0,-2
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-2
.debug_ranges,0,-16
.debug_line,0,-54
[Unmapped],0,-112

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize
.debug_str,0,32
.debug_info,0,18
.flash.rodata,8,8
.debug_loc,0,6
[Unmapped],0,-8

[andy31415]

nit: should "unsigned char" here be uint8_t for consistency with the rest of the codebase?

Realise this code is not really changed at this level, so optional change for sure if it even makes sense.

[pan-apple]

WaitForPairing is exposed to the rest of the code as an API, and it currently takes unsigned char as the argument. We should be able to change it to uint8_t, but maybe better to do this in a separate PR.