Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cleanup PASE code, error handling and error logging" #6896

Merged
merged 1 commit into from
May 17, 2021

Conversation

woody-apple
Copy link
Contributor

Reverts #6852

Breaks the tree, reverting this. Not sure why this worked against PR, but not main.

@boring-cyborg boring-cyborg bot added the lib label May 17, 2021
@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label May 17, 2021
@woody-apple woody-apple merged commit 6bfdd05 into master May 17, 2021
@woody-apple woody-apple deleted the revert-6852-pase-cleanup branch May 17, 2021 20:30
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from fdb60ef

File Section File VM
chip-lighting.elf text -80 -80
chip-lighting.elf rodata -104 -104
chip-lock.elf text -80 -80
chip-lock.elf rodata -104 -104
chip-shell.elf rodata -8 -8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_line,0,49
.shstrtab,0,-3
.debug_frame,0,-4
.debug_aranges,0,-8
.debug_ranges,0,-24
.debug_abbrev,0,-33
text,-80,-80
.symtab,0,-96
rodata,-104,-104
.strtab,0,-153
.debug_str,0,-185
.debug_loc,0,-531
.debug_info,0,-1336

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_line,0,52
.shstrtab,0,1
.debug_frame,0,-4
.debug_aranges,0,-8
.debug_ranges,0,-24
.debug_abbrev,0,-33
text,-80,-80
.symtab,0,-96
rodata,-104,-104
.strtab,0,-153
.debug_str,0,-185
.debug_loc,0,-531
.debug_info,0,-1323

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_loc,0,16
.debug_line,0,-2
rodata,-8,-8
.debug_str,0,-32
.debug_info,0,-366


@github-actions
Copy link

Size increase report for "esp32-example-build" from fdb60ef

File Section File VM
chip-pigweed-app.elf .flash.rodata -8 -8
chip-all-clusters-app.elf .flash.text -56 -56
chip-all-clusters-app.elf .flash.rodata -104 -104
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize
[Unmapped],0,8
.debug_loc,0,-6
.flash.rodata,-8,-8
.debug_info,0,-18
.debug_str,0,-32

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,104
.shstrtab,0,-1
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-1
.debug_aranges,0,-8
.debug_line,0,-10
.symtab,0,-16
.debug_abbrev,0,-20
.debug_frame,0,-24
.debug_ranges,0,-56
.flash.text,-56,-56
.flash.rodata,-104,-104
.debug_str,0,-185
.strtab,0,-203
.debug_loc,0,-331
.debug_info,0,-1529


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant