Fixing restyled to ignore third_party #392
Conversation
woody-apple
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk and
tpmanley
as code owners
|
Not sure why the restyled check is counting here (build fails because branch is gone)... |
| - "third_party/**/*" | ||
| - "third_party/**" | ||
| - "third_party/*" |
There was a problem hiding this comment.
this is really unfortunate. is restyled really this stupid?
There was a problem hiding this comment.
Not sure it is a multiple 'really' level of unfortunate, but it seems to work for now. Trying to pair it back down as I understand their syntax.
There was a problem hiding this comment.
fixed to single level really
| - "third_party/**/*" | ||
| - "third_party/**" | ||
| - "third_party/*" | ||
| - "build/**/*" |
There was a problem hiding this comment.
we want restyled looking at build, as long as the files are part of the git repository
There was a problem hiding this comment.
"We want" can you explain? which we don't want?
There was a problem hiding this comment.
we want restyled to look at all the things in build/ that are in git
There was a problem hiding this comment.
This should be addressed separately. For now, we're should ignore build, we can bring this back in later.
There was a problem hiding this comment.
Aside: Ideally, we should have a real build directory then, given it's a mix of built products, and scripts
| - "third_party/**" | ||
| - "third_party/*" | ||
| - "build/**/*" | ||
| - "autom4te.cache/**/*" |
There was a problem hiding this comment.
there are no files in this directory in git...
There was a problem hiding this comment.
Yup, but it matters for locally restyled
There was a problem hiding this comment.
restyled can't look at .gitignore? I guess this is no biggie, but it means .gitignore and this file have to be kept in sync.
There was a problem hiding this comment.
Correct, feel free to open up an issue there.
| corresponding to the number of months since January 1, 2020, and generally mean | ||
| the last Friday of that month. E.g. M1 corresponds to EOB January 24, | ||
|
|
||
| 2020. The Morrow milestone is a special milestone that means "unprioritized" or |
There was a problem hiding this comment.
this is a misfire, "2020." isn't a numbered list item.
There was a problem hiding this comment.
It's following the default .md formatter. Do we have a config anywhere we should use? We are not going to manually verify each thing the restyler does and accept/decline it.
There was a problem hiding this comment.
I think we should probably just trick the thing by wrapping it another way
yes: I plan to verify everything the restyler does, lest we break our tree.
Merge in WMN_TOOLS/matter from feature/wifi_gsdk_integration_slc_1.0 to silabs_slc_1.0 Squashed commit of the following: commit 819dccc274991177cf95ea95ddf5219b9affe87a Author: Rehan Rasool <[email protected]> Date: Thu Dec 15 15:26:50 2022 -0500 Remove brd4187c from supported wi-fi boards as it does not compile commit 9934ca51034e338aab1bcf7e2a031c4f98e8e090 Author: Rehan Rasool <[email protected]> Date: Thu Dec 15 14:31:20 2022 -0500 Fix Wi-Fi stash name so when SQA stage is enabled, it works same way as it does for Ninja builds commit 305a3d7e4a953e359c3102640651899d072f912f Author: Rehan Rasool <[email protected]> Date: Thu Dec 15 14:28:21 2022 -0500 Fix missed board compatibilities for wi-fi apps ... and 25 more commits
Problem
third_party is kicking restyled, need to fix that
Summary of Changes
Ongoing... testing