[format] Manually correct code style of examples. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turon
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
gerickson,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
woody-apple
requested changes
Apr 17, 2020
|
Note: Later today or this weekend I plan on putting up an Uber format-fixing patch, as Make Pretty doesn’t cover all headers and source, as well as we need to get everything up to scratch with restyled. |
|
@turon I also see one problem, you need to rebase your branch, you’re using a very old restyled config here |
turon
force-pushed
the
pr/style/examples
branch
from
630ec62 to
7fc96cd
Compare
turon
force-pushed
the
pr/style/examples
branch
from
7fc96cd to
c10689e
Compare
|
Rebased over #392 and restyled auto-closed it's issues as expected. Cool! |
woody-apple
approved these changes
Apr 17, 2020
jwhui
reviewed
Apr 17, 2020
turon
force-pushed
the
pr/style/examples
branch
from
46bba45 to
f812d1b
Compare
turon
force-pushed
the
pr/style/examples
branch
from
f812d1b to
7601482
Compare
BroderickCarlin
approved these changes
Apr 18, 2020
jelderton
approved these changes
Apr 20, 2020
|
these examples are deliberately excluded from restyled's scans |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Make example sources code style compliant to prevent restyled getting involved whenever these files are touched.
Summary of Changes
Manual run of clang-format on examples.
workaround #345 until resolved