Fixing restyled to ignore third_party #392
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| # Do anything at all | ||
| enabled: true | ||
|
|
||
| # Push the style fixes directly to the original PR | ||
| auto: false | ||
|
|
||
| # Open Restyle PRs? | ||
| pull_requests: true | ||
|
|
||
| # Add labels to any created Restyle PRs | ||
| labels: | ||
| - restyled | ||
|
|
||
| # Labels to ignore | ||
| ignore_labels: | ||
| - restyled-ignore | ||
|
|
||
| # Leave comments on the original PR linking to the Restyle PR? | ||
| comments: false | ||
|
|
||
| # Request review on the Restyle PR | ||
| request_review: none | ||
|
|
||
| # Patterns to exclude from all Restylers | ||
| exclude: | ||
| - ".github/workflows/**/*" # https://github.com/restyled-io/restyler/issues/73 | ||
| - "third_party/**/*" | ||
| - "build/**/*" | ||
| - "autom4te.cache/**/*" | ||
|
There was a problem hiding this comment. there are no files in this directory in git... There was a problem hiding this comment. Yup, but it matters for locally restyled There was a problem hiding this comment. restyled can't look at .gitignore? I guess this is no biggie, but it means .gitignore and this file have to be kept in sync. There was a problem hiding this comment. Correct, feel free to open up an issue there. |
||
|
|
||
| # Restylers to run, and how | ||
| restylers: | ||
| - name: clang-format | ||
| enabled: true | ||
| image: restyled/restyler-clang-format:v9.0.0 | ||
| command: | ||
| - clang-format | ||
| - "-i" | ||
| arguments: [] | ||
| include: | ||
| - "**/*.c" | ||
| - "**/*.cc" | ||
| - "**/*.cpp" | ||
| - "**/*.cxx" | ||
| - "**/*.c++" | ||
| - "**/*.C" | ||
| - "**/*.cs" | ||
| - "**/*.h" | ||
| - "**/*.hh" | ||
| - "**/*.hpp" | ||
| - "**/*.hxx" | ||
| - "**/*.h++" | ||
| - "**/*.H" | ||
| - "**/*.java" | ||
| - "**/*.js" | ||
| - "**/*.m" | ||
| interpreters: [] | ||
| - name: prettier-json | ||
| enabled: true | ||
| include: | ||
| - "**/*.json" | ||
| - name: prettier-markdown | ||
| enabled: true | ||
| include: | ||
| - "**/*.md" | ||
| - "**/*.markdown" | ||
| - name: prettier-yaml | ||
| enabled: true | ||
| include: | ||
| - "**/*.yml" | ||
| - "**/*.yaml" | ||
| - name: shellharden | ||
| enabled: true | ||
| include: | ||
| - "**/*.sh" | ||
| - "**/*.bash" | ||
| - name: shfmt | ||
| enabled: true | ||
| include: | ||
| - "**/*.sh" | ||
| - "**/*.bash" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want restyled looking at build, as long as the files are part of the git repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"We want" can you explain? which we don't want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want restyled to look at all the things in build/ that are in git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be addressed separately. For now, we're should ignore build, we can bring this back in later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: Ideally, we should have a real build directory then, given it's a mix of built products, and scripts