[Logging] Log the duration for successfully establishing a subscription #36115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36115: Size comparison from 150db87 to c189648 Full report (20 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, qpg, stm32, tizen)
|
vivien-apple
force-pushed
the
Logging_SubscriptionEstablished
branch
from
c189648 to
ae37268
Compare
|
PR #36115: Size comparison from 150db87 to ae37268 Full report (39 builds for linux, nrfconnect, stm32, telink, tizen)
|
vivien-apple
force-pushed
the
Logging_SubscriptionEstablished
branch
from
ae37268 to
acb5605
Compare
|
PR #36115: Size comparison from 150db87 to acb5605 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 17, 2024
woody-apple
approved these changes
Oct 18, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now, there’s no way to see how long it actually takes to set up a subscription just by looking at the logs.
This makes it a bit tough for anyone relying on logging (and not a full tracing system) to get a sense of timing when subscriptions are established.
Having some basic timing info would be helpful, especially when debugging performance or responsiveness issues.
This PR log the time taken once the subscription is confirmed, available only when progress logging is enabled.