Manual fixes

project-chip · Sep 1, 2021 · 1647644 · 1647644
1 parent 165990b
commit 1647644
Show file tree

Hide file tree

Showing 32 changed files with 70 additions and 99 deletions.
diff --git a/examples/chip-tool/templates/commands.zapt b/examples/chip-tool/templates/commands.zapt
@@ -5,10 +5,10 @@
 #include <cstdint>
 
 #include <commands/clusters/ModelCommand.h>
-#include <zap-generated/CHIPClientCallbacks.h>
-#include <zap-generated/CHIPClusters.h>
 #include <lib/core/CHIPSafeCasts.h>
 #include <lib/support/BytesToHex.h>
+#include <zap-generated/CHIPClientCallbacks.h>
+#include <zap-generated/CHIPClusters.h>
 
 static void OnDefaultSuccessResponse(void * context)
 {

diff --git a/examples/platform/nrfconnect/util/DFUTrigger.cpp b/examples/platform/nrfconnect/util/DFUTrigger.cpp
@@ -21,7 +21,7 @@
 #endif
 
 #include <drivers/gpio.h>
-#include <lib/shell/shell.h>
+#include <shell/shell.h>
 
 namespace {
 constexpr const char * kGPIOController = "GPIO_0";

diff --git a/src/app/zap-templates/templates/app/CHIPClusters-src.zapt b/src/app/zap-templates/templates/app/CHIPClusters-src.zapt
@@ -5,19 +5,17 @@
 
 #include <cstdint>
 
+
+#include <app/InteractionModelEngine.h>
+#include <app/chip-zcl-zpro-codec.h>
+#include <app/util/basic-types.h>
+#include <app-common/zap-generated/ids/Attributes.h>
 #include <lib/support/BufferWriter.h>
+#include <lib/support/CodeUtils.h>
 #include <lib/support/SafeInt.h>
 #include <lib/support/logging/CHIPLogging.h>
 #include <system/SystemPacketBuffer.h>
-
-#include <app/chip-zcl-zpro-codec.h>
-#include <app-common/zap-generated/ids/Attributes.h>
-#include <app/util/basic-types.h>
-
 #include <zap-generated/CHIPClientCallbacks.h>
-#include <lib/support/SafeInt.h>
-#include <lib/support/CodeUtils.h>
-#include <app/InteractionModelEngine.h>
 
 #define COMMAND_HEADER(name, clusterId)                                                                                            \
     const char * kName = name;                                                                                                     \

diff --git a/src/app/zap-templates/templates/app/af-structs.zapt b/src/app/zap-templates/templates/app/af-structs.zapt
@@ -4,8 +4,10 @@
 #pragma once
 
 #include <stdint.h>
+
 #include <app/util/basic-types.h>
 #include <lib/support/Span.h>
+
 #include "enums.h"
 
 {{#zcl_structs}}

diff --git a/src/controller/java/templates/CHIPClusters-JNI.zapt b/src/controller/java/templates/CHIPClusters-JNI.zapt
@@ -8,10 +8,10 @@
 #include <controller/java/JniReferences.h>
 #include <controller/java/JniTypeWrappers.h>
 #include <controller/java/StackLock.h>
-#include <lib/core/CHIPSafeCasts.h>
-#include <lib/support/Span.h>
 #include <jni.h>
+#include <lib/core/CHIPSafeCasts.h>
 #include <lib/support/CodeUtils.h>
+#include <lib/support/Span.h>
 
 #define JNI_METHOD(RETURN, CLASS_NAME, METHOD_NAME)                                                                                            \
     extern "C" JNIEXPORT RETURN JNICALL Java_chip_devicecontroller_ChipClusters_00024##CLASS_NAME##_##METHOD_NAME

diff --git a/src/controller/python/chip/clusters/CHIPClusters.cpp b/src/controller/python/chip/clusters/CHIPClusters.cpp
diff --git a/src/controller/python/templates/python-CHIPClusters-cpp.zapt b/src/controller/python/templates/python-CHIPClusters-cpp.zapt
@@ -1,9 +1,8 @@
 {{> header}}
 
-#include <lib/core/CHIPCore.h>
-
 #include <app/CommandSender.h>
 #include <app/InteractionModelEngine.h>
+#include <lib/core/CHIPCore.h>
 #include <lib/support/Span.h>
 
 #include <controller/CHIPDevice.h>

diff --git a/src/credentials/CHIPCert.h b/src/credentials/CHIPCert.h
@@ -27,6 +27,7 @@
 
 #pragma once
 
+#include <cstdint>
 #include <string.h>
 
 #include <crypto/CHIPCryptoPAL.h>

diff --git a/src/credentials/tests/CHIPCert_test_vectors.h b/src/credentials/tests/CHIPCert_test_vectors.h
@@ -26,7 +26,6 @@
 
 #pragma once
 
-#include <lib/asn1/ASN1OID.h>
 #include <lib/core/CHIPConfig.h>
 #include <lib/support/BitFlags.h>
 #include <lib/support/CodeUtils.h>

diff --git a/src/darwin/Framework/CHIP/CHIPManualSetupPayloadParser.mm b/src/darwin/Framework/CHIP/CHIPManualSetupPayloadParser.mm
@@ -20,9 +20,9 @@
 #import "CHIPLogging.h"
 #import "CHIPSetupPayload_Internal.h"
 
+#import <lib/support/CHIPMem.h>
 #import <setup_payload/ManualSetupPayloadParser.h>
 #import <setup_payload/SetupPayload.h>
-#import <support/CHIPMem.h>
 
 @implementation CHIPManualSetupPayloadParser {
     NSString * _decimalStringRepresentation;

diff --git a/src/darwin/Framework/CHIP/CHIPQRCodeSetupPayloadParser.mm b/src/darwin/Framework/CHIP/CHIPQRCodeSetupPayloadParser.mm
@@ -20,9 +20,9 @@
 #import "CHIPLogging.h"
 #import "CHIPSetupPayload_Internal.h"
 
+#import <lib/support/CHIPMem.h>
 #import <setup_payload/QRCodeSetupPayloadParser.h>
 #import <setup_payload/SetupPayload.h>
-#import <support/CHIPMem.h>
 
 @implementation CHIPQRCodeSetupPayloadParser {
     NSString * _base38Representation;

diff --git a/src/lib/BUILD.gn b/src/lib/BUILD.gn
@@ -15,10 +15,6 @@
 import("//build_overrides/chip.gni")
 import("lib.gni")
 
-config("includes") {
-  include_dirs = [ "." ]
-}
-
 static_library("lib") {
   public_deps = [
     "${chip_root}/src/app",

diff --git a/src/lib/asn1/ASN1.h b/src/lib/asn1/ASN1.h
@@ -48,7 +48,7 @@ namespace chip {
 namespace ASN1 {
 
 #ifndef DOXYGEN_SHOULD_SKIP_THIS
-#include <lib/asn1/ASN1OID.h>
+#include <asn1/ASN1OID.h>
 #endif
 
 static constexpr size_t kMaxConstructedAndEncapsulatedTypesDepth = 10;

diff --git a/src/lib/asn1/BUILD.gn b/src/lib/asn1/BUILD.gn
@@ -51,7 +51,6 @@ static_library("asn1") {
 
   public_configs = [
     "${chip_root}/src:includes",
-    "${chip_root}/src/lib:includes",
     "${chip_root}/src/system:system_config",
   ]
 }
diff --git a/src/lib/asn1/tests/TestASN1.cpp b/src/lib/asn1/tests/TestASN1.cpp
@@ -30,11 +30,9 @@
 #include <stdio.h>
 #include <string.h>
 
-#include <lib/support/UnitTestRegistration.h>
-
 #include <lib/asn1/ASN1.h>
 #include <lib/asn1/ASN1Macros.h>
-#include <lib/asn1/ASN1OID.h>
+#include <lib/support/UnitTestRegistration.h>
 
 using namespace chip;
 using namespace chip::ASN1;

diff --git a/src/lib/core/BUILD.gn b/src/lib/core/BUILD.gn
@@ -69,10 +69,7 @@ source_set("chip_config_header") {
     "CHIPTimeConfig.h",
   ]
 
-  public_configs = [
-    "${chip_root}/src:includes",
-    "${chip_root}/src/lib:includes",
-  ]
+  public_configs = [ "${chip_root}/src:includes" ]
 
   public_deps = [
     ":chip_buildconfig",

diff --git a/src/lib/core/CHIPConfig.h b/src/lib/core/CHIPConfig.h
@@ -36,7 +36,7 @@
 #pragma once
 
 #if CHIP_HAVE_CONFIG_H
-#include <lib/core/CHIPBuildConfig.h>
+#include <core/CHIPBuildConfig.h>
 #endif
 
 #include <ble/BleConfig.h>

diff --git a/src/lib/mdns/Discovery_ImplPlatform.cpp b/src/lib/mdns/Discovery_ImplPlatform.cpp
@@ -15,23 +15,23 @@
  *    limitations under the License.
  */
 
-#include "Discovery_ImplPlatform.h"
-#include "MdnsCache.h"
+#include <lib/mdns/Discovery_ImplPlatform.h>
 
 #include <inttypes.h>
 
-#include "ServiceNaming.h"
-#include "lib/core/CHIPSafeCasts.h"
-#include "lib/mdns/TxtFields.h"
-#include "lib/mdns/platform/Mdns.h"
-#include "lib/support/logging/CHIPLogging.h"
-#include "platform/CHIPDeviceConfig.h"
-#include "platform/CHIPDeviceLayer.h"
 #include <lib/core/CHIPConfig.h>
+#include <lib/core/CHIPSafeCasts.h>
+#include <lib/mdns/MdnsCache.h>
+#include <lib/mdns/ServiceNaming.h>
+#include <lib/mdns/TxtFields.h>
+#include <lib/mdns/platform/Mdns.h>
 #include <lib/support/CHIPMemString.h>
 #include <lib/support/CodeUtils.h>
 #include <lib/support/ErrorStr.h>
 #include <lib/support/RandUtils.h>
+#include <lib/support/logging/CHIPLogging.h>
+#include <platform/CHIPDeviceConfig.h>
+#include <platform/CHIPDeviceLayer.h>
 
 namespace chip {
 namespace Mdns {

diff --git a/src/lib/mdns/Resolver_ImplMinimalMdns.cpp b/src/lib/mdns/Resolver_ImplMinimalMdns.cpp
@@ -20,11 +20,9 @@
 
 #include <limits>
 
-#include "MinimalMdnsServer.h"
-#include "ServiceNaming.h"
-
 #include <lib/core/CHIPConfig.h>
-
+#include <lib/mdns/MinimalMdnsServer.h>
+#include <lib/mdns/ServiceNaming.h>
 #include <lib/mdns/TxtFields.h>
 #include <lib/mdns/minimal/Parser.h>
 #include <lib/mdns/minimal/QueryBuilder.h>

diff --git a/src/lib/mdns/platform/Mdns.h b/src/lib/mdns/platform/Mdns.h
@@ -28,11 +28,11 @@
 #include <algorithm>
 #include <stdint.h>
 
-#include "inet/IPAddress.h"
-#include "inet/InetInterface.h"
-#include "lib/core/Optional.h"
-#include "lib/mdns/ServiceNaming.h"
+#include <inet/IPAddress.h>
+#include <inet/InetInterface.h>
 #include <lib/core/CHIPError.h>
+#include <lib/core/Optional.h>
+#include <lib/mdns/ServiceNaming.h>
 
 namespace chip {
 namespace Mdns {

diff --git a/src/lib/mdns/tests/TestMdnsCache.cpp b/src/lib/mdns/tests/TestMdnsCache.cpp
@@ -15,21 +15,21 @@
  *    See the License for the specific language governing permissions and
  *    limitations under the License.
  */
-#include <lib/support/logging/CHIPLogging.h>
+
 // set this to 1 to enable DumpCache to see the state of the cache when needed
 // #define MDNS_LOGGING 1
-#include <iostream>
-#include <lib/mdns/MdnsCache.h>
-
 #include <cstdint>
-#include <lib/support/UnitTestRegistration.h>
+#include <iostream>
 #include <nlunit-test.h>
 
 #include <inet/IPAddress.h>
 #include <inet/InetInterface.h>
 #include <inet/InetLayer.h>
 #include <lib/core/CHIPError.h>
 #include <lib/core/PeerId.h>
+#include <lib/mdns/MdnsCache.h>
+#include <lib/support/UnitTestRegistration.h>
+#include <lib/support/logging/CHIPLogging.h>
 #include <system/SystemTimer.h>
 #include <system/TimeSource.h>
 

diff --git a/src/lib/shell/MainLoopZephyr.cpp b/src/lib/shell/MainLoopZephyr.cpp
@@ -15,7 +15,7 @@
  *    limitations under the License.
  */
 #include <init.h>
-#include <lib/shell/shell.h>
+#include <shell/shell.h>
 
 #include <lib/core/CHIPError.h>
 #include <lib/shell/Engine.h>

diff --git a/src/lib/shell/streamer_zephyr.cpp b/src/lib/shell/streamer_zephyr.cpp
@@ -24,8 +24,8 @@
 
 #include <cassert>
 
-#include <lib/shell/shell.h>
-#include <lib/shell/shell_uart.h>
+#include <shell/shell.h>
+#include <shell/shell_uart.h>
 
 namespace chip {
 namespace Shell {

diff --git a/src/lib/support/BUILD.gn b/src/lib/support/BUILD.gn
@@ -144,7 +144,6 @@ static_library("support") {
 
   public_configs = [
     "${chip_root}/src:includes",
-    "${chip_root}/src/lib:includes",
     "${chip_root}/src/system:system_config",
   ]
 

diff --git a/src/platform/logging/impl/android/Logging.cpp b/src/platform/logging/impl/android/Logging.cpp
@@ -1,7 +1,7 @@
 /* See Project chip LICENSE file for licensing information. */
 
-#include "platform/logging/LogV.h"
 #include <lib/support/logging/Constants.h>
+#include <platform/logging/LogV.h>
 
 #include <android/log.h>
 

diff --git a/src/tools/chip-cert/chip-cert.h b/src/tools/chip-cert/chip-cert.h
@@ -52,7 +52,6 @@
 #include <CHIPVersion.h>
 #include <credentials/CHIPCert.h>
 #include <lib/asn1/ASN1.h>
-#include <lib/asn1/ASN1OID.h>
 #include <lib/core/CHIPConfig.h>
 #include <lib/core/CHIPCore.h>
 #include <lib/core/CHIPSafeCasts.h>

diff --git a/zzz_generated/app-common/app-common/zap-generated/af-structs.h b/zzz_generated/app-common/app-common/zap-generated/af-structs.h
diff --git a/zzz_generated/controller-clusters/zap-generated/CHIPClusters.cpp b/zzz_generated/controller-clusters/zap-generated/CHIPClusters.cpp
diff --git a/zzz_generated/lighting-app/zap-generated/CHIPClusters.cpp b/zzz_generated/lighting-app/zap-generated/CHIPClusters.cpp