Switch DataModel::Provider interface to default enabled (except on linux where it stays as check)
#36042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
… Still 100% ember tied.
|
chip-k32w0x-light-example does not fit in flash anymore ... that is not good at all. Looking through the rest of the failures and will have separate PRs to fix them. |
|
Converted to draft: we need to figure out all build failures and even then figure out how to manage flash increases. |
…s be a private dependency
… with dynamic dispatcher. Dynamic dispatcher seems to only care about commands so implemented all the rest as empty, which is not ideal
…ogress logging and up (no detail/automation)
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
…ult_enable_dm_provider
…ult_enable_dm_provider
|
PR #36042: Size comparison from 3d80093 to 5e230fa Increases above 0.2%:
Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 31, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…linux where it stays as check) (project-chip#36042) * Switch data model provider usage to default to enabled * Decouple pump configuration and control from compatibility functions. Still 100% ember tied. * Fix up some private/public dependencies: instance header should always be a private dependency * Allow java (or generally dynamic server) controller builds to compile with dynamic dispatcher. Dynamic dispatcher seems to only care about commands so implemented all the rest as empty, which is not ideal * Restyled by clang-format * Restyled by gn * Better dynamic dispatch implementation, removed extra TODO functions * Restyled by whitespace * Update dep a bit more * Fix linter * Fix linter again * Update NXP to support various logging targets and for K32W0 enable progress logging and up (no detail/automation) * Fix nxp compile (ordering issue) * Update logic a bit to use log level for low power * Update builds to consider low power already removing logs * Make microwave oven cluster compilable * Restyle * Add codegen data model to darwin xproject: given that we add ember, we need these to access the ember bits as there is no app or data model to provide these * Add missing override for darwin dispatch when codegen data model uses lower level methods for ember access * Fix linter * Add ability to track structural changes in ember for the purpose of codegen data model caching * Fix typo: uint is unsigned * Restyle * Fix android to also provide a generation version * Fix another uint/unsigned typo ... oops * Add assertion of stack lock in darwin override of emberAfWriteAttribute * Restyled by isort * Remove formatting changes from python files * Pick up restyle changes too * Add comment on attribute laregest * Use TLV-based encoding for ember data buffer. This saves 2K of flash on some test devices, being much more efficient in code size compared to using datamodel code. * Restyled by clang-format * Restyled by shfmt * Undo unrelated change * Add some casts to make android compiler happy * Update darwin build project as well with the new files * Updates based on code review * Added unit tests for min/max int64 values * Rename PascalString to PascalStringType * Fix rename * Restyle * Add helper methods inside odd sized integers to localize code logic * Restyled by clang-format * Fix up negative ranges * Fixed ranges * Fix signed max bug and update unit tests * Make android happy * Typo fix * Switch up unit tests * Update a nullable check to make use of ValueToNullValue * Add namespace prefix * Update src/app/codegen-data-model-provider/EmberDataBuffer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/codegen-data-model-provider/EmberDataBuffer.h Co-authored-by: Boris Zbarsky <[email protected]> * Correct comments:signed, not unsigned * Use constructors for the buffer info * Rename things to EmberAttributeDataBuffer * Undo submodule updates * Restyled by clang-format * Use EmberAttributeDataBuffer for codegen provider _Read * Fix comments * Restyled by clang-format * Update DynamicDispatcher comment * Rename file * Use a pointer for the subject descriptor. This seems to save about 88 bytes of flash on a test NRF board. * Restyle * Fix include * Fix include * Also fix PW rpc * This saves 136 bytes... * More changes to save slightly more flash for code * Restyle * Fix typo * Fix includes * make more detailed logging optional in the codegen data model and enable it only on known large platforms * Pull back the event path validity mixin, start with a datamodel implementation * Fix compile logic after I moved things away * Add one more check * Restyle * Fix typo * Fix includes * Restyle * Move decodable lists bits as a non-template class to save flash * Update src/app/InteractionModelEngine.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Rename method * Restyle * More renames * Restyle * Fix some renames * Restyle * A few more renames * Restyle * Use chip::app::IsSignedAttributeType * Fix up put as well as naming for null value and comment * Fix up nullable tests * Test that you cannot decode a null value for non-nullable double and single * Allow NAN for non-nullable floating points * Add test case for non nullable bool * Restyle * Add a header for efr32 * Update src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Remove extra comment * Replace switch with if * Comment fix * Another try to make efr32 build of tests happy * Move includes around, to try to work around issues within efr32 compiles... * more updates, this time local efr32 compiles * Remove lookup tables from ember attribute data buffer --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will switch from using ember-compatibility-functions.cpp to using the codegen datamodel provider.
PR should show FLASH and RAM sideffect as well as if any compilation issues may occur.
Changes
Size notes