Make TLVReader/Writer consume slightly less flash #36286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
jmartinez-silabs
approved these changes
Oct 29, 2024
andy31415
commented
Oct 29, 2024
|
PR #36286: Size comparison from 3d80093 to f77311a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 30, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #36286: Size comparison from 3d80093 to a84da17 Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Size reductions: 80 bytes for TLV reader * Tiny reduction in code size, slight improvement on readability * Another tiny code diff and readability improvement * Size decrease for TLVWriter as well * Readability update * Restyle * Restyled by clang-format * Pay a bit of price for initialization, but this makes clang-tidy happy (I hope) * Update to make flash smaller with an odd workaround * Add back size comment * Update src/lib/core/TLVReader.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Add skip over control byte comment * Added a new comment * Restyled by whitespace --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the methods seemed large in reports. I could not find very large savings, however this still saves a bit over 100 bytes of flash for a sample NRF light.
Readability may also be ever so slightly improved (at least less lines of code)