Make datamodel-provider inteface logging optional/configurable #36249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble it only on known large platforms
|
Review changes with SemanticDiff. |
|
PR #36249: Size comparison from 90052aa to 597d206 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 25, 2024
yufengwangca
approved these changes
Oct 25, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #36249: Size comparison from 90052aa to 1ed518f Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ct-chip#36249) * make more detailed logging optional in the codegen data model and enable it only on known large platforms * Update src/app/common_flags.gni Co-authored-by: Boris Zbarsky <[email protected]> * Restyled by gn --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodegenDatamodelProvider (and DataModel::Provider) has more checks and error logs than the methods it replaces. Since CodegenDataModel switch in #36246 has concerns on codesize, make this extra logging configurable.
Logging is enabled on known large platforms (linux, darwin and android) and disabled otherwise. Depending on flash amount, we may want to start enabling this on other platforms.
This saves about 490 bytes of flash when the extra logging is disabled.