[ICD] Add subscriber request max interval getter #36021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #36021: Size comparison from 7a9bd66 to 5665eda Increases above 0.2%:
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Oct 11, 2024
mkardous-silabs
force-pushed
the
fix/icd_readhandler
branch
from
5665eda to
cbdf773
Compare
|
PR #36021: Size comparison from 55a6c6b to cbdf773 Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
approved these changes
Oct 11, 2024
|
@yunhanw-google @andy31415 I think this commit needs cherry-pick to v1.4-branch. |
mkardous-silabs
added a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Oct 21, 2024
* Add subscriber request max interval getter * Add unit-test for the SetMaxReportingInterval * Restyled by clang-format * fix conversation error * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
|
@fuxiaoming-lumi Cherry-pick PR is open #36176 |
andy31415
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Add subscriber request max interval getter * Add unit-test for the SetMaxReportingInterval * Restyled by clang-format * fix conversation error * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Add subscriber request max interval getter * Add unit-test for the SetMaxReportingInterval * Restyled by clang-format * fix conversation error * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When #28375 was merged to add a default subscription behavior to the subscription establishment, the MaxInterval of the readhandler is changed to the default ICD behavior with the expectation that this behavior can be changed with the OnSubscriptionEstablished callback.
The issue is that since we overrule the request MaxInterval, the application API doesn't have a way of knowing the requested max interval from the subscriber to do its decision making. This also impacted the SetMaxInterval function where we were changing the allow maximum which could decrease the spec allowed max interval selection.
PR adds a member that stores the subscriber max interval that can be accessed by the application without impacting the SetMaxInterval function
Fixes #35991
Tests
Added a unit test to validate the SetMaxInterval readhandler function