Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unable to get correct MaxIntervalCeiling in OnSubscriptionRequested for ICD #35991

Closed
fuxiaoming-lumi opened this issue Oct 9, 2024 · 3 comments · Fixed by #36021
Closed

[BUG] Unable to get correct MaxIntervalCeiling in OnSubscriptionRequested for ICD #35991

fuxiaoming-lumi opened this issue Oct 9, 2024 · 3 comments · Fixed by #36021
Assignees
@mkardous-silabs
Labels
bug Something isn't working icd Intermittently Connected Devices needs triage

Comments

@fuxiaoming-lumi
Copy link
Contributor

fuxiaoming-lumi commented Oct 9, 2024 •
edited
Loading

Reproduction steps

When using ReadHandler::ApplicationCallback to implement a custom strategy, you will not be able to get the MaxIntervalCeiling in OnSubscriptionRequested for ICD devices.

We only have GetReportingIntervals API and it get mMaxInterval but is overridden.

connectedhomeip/src/app/ReadHandler.cpp

Line 744 in 5224cec

ReturnErrorOnFailure(subscribeRequestParser.GetMaxIntervalCeilingSeconds(&mMaxInterval));

connectedhomeip/src/app/ReadHandler.cpp

Line 794 in 5224cec

mMaxInterval = static_cast<uint16_t>(decidedMaxInterval);

Bug prevalence

100%

GitHub hash of the SDK that was being used

5224cec

Platform

core

Platform Version(s)

No response

Anything else?

No response
@fuxiaoming-lumi fuxiaoming-lumi added bug Something isn't working needs triage labels Oct 9, 2024
@bzbarsky-apple
Copy link
Contributor

@lpbeliveau-silabs

@bzbarsky-apple bzbarsky-apple added the icd Intermittently Connected Devices label Oct 9, 2024
@lpbeliveau-silabs lpbeliveau-silabs self-assigned this Oct 9, 2024
@fuxiaoming-lumi
Copy link
Contributor Author

More details https://csamembers.slack.com/archives/C036A932BQ8/p1728399013259439

@mkardous-silabs mkardous-silabs mentioned this issue Oct 10, 2024
Merged
@fuxiaoming-lumi
Copy link
Contributor Author

@yunhanw-google @mkardous-silabs @andy31415 I think we also need cherry-pick this commit to v1.4-branch.

@mkardous-silabs mkardous-silabs mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkardous-silabs mkardous-silabs

Labels
bug Something isn't working icd Intermittently Connected Devices needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ICD] Add subscriber request max interval getter mkardous-silabs/connectedhomeip
4 participants
@bzbarsky-apple @fuxiaoming-lumi @mkardous-silabs @lpbeliveau-silabs