-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add default ICD Behavior to readhandler when establishing a subscription #28375
Merged
mkardous-silabs
merged 10 commits into
project-chip:master
from
mkardous-silabs:feature/sub_max
Aug 1, 2023
Merged
[ICD] Add default ICD Behavior to readhandler when establishing a subscription #28375
mkardous-silabs
merged 10 commits into
project-chip:master
from
mkardous-silabs:feature/sub_max
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 28, 2023 16:19
jmartinez-silabs
approved these changes
Jul 28, 2023
mkardous-silabs
force-pushed
the
feature/sub_max
branch
from
August 1, 2023 13:41
5ea215d
to
7adce88
Compare
PR #28375: Size comparison from 4ac9304 to 7adce88 Increases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
mkardous-silabs
force-pushed
the
feature/sub_max
branch
from
August 1, 2023 14:20
2a92fe5
to
7b4ca59
Compare
PR #28375: Size comparison from 4a2d6e9 to 97119f0 Increases (9 builds for bl702, bl702l, cc32xx, k32w, psoc6)
Decreases (3 builds for cc32xx, cyw30739, psoc6)
Full report (29 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28375: Size comparison from 4a2d6e9 to b5ff2df Increases (17 builds for bl602, bl702, bl702l, cc32xx, k32w, psoc6, telink)
Decreases (7 builds for bl602, bl702l, cc32xx, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
doru91
added a commit
to NXP/matter
that referenced
this pull request
Aug 4, 2023
Use the default readhandler introduced by project-chip#28375, instead of the custom one. Signed-off-by: Doru Gucea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds a default behavior for ICDs when establishing a subscription where the ICD tries to set its IdleModeInterval as the MaxInterval of the subscription.
Default behavior steps :