[Darwin] Enable taking assertion on MTRDeviceController #35148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
Aug 22, 2024
anush-apple
commented
- Added ability to take assertion on MTRDeviceController to keep it running until all assertions are removed
- A request to shutdown will take place only if there are no assertions are present
- Added ability to take assertion on MTRDeviceController to keep it running until all assertions are removed - A request to shutdown will take place only if there are no assertions are present
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
kkasperczyk-no
|
PR #35148: Size comparison from 07789d4 to 910c152 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35148: Size comparison from 07789d4 to 0b3cf45 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35148: Size comparison from 07789d4 to b48b288 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35148: Size comparison from 07789d4 to 198eaae Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35148: Size comparison from 07789d4 to 35d220e Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 23, 2024
src/darwin/Framework/CHIP/MTRDeviceControllerStartupParams_Internal.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
This was referenced Aug 23, 2024
|
Fast-tracking platform-specific fix with platform owner review. |
anush-apple
added a commit
to anush-apple/connectedhomeip
that referenced
this pull request
Aug 26, 2024
… fabric as well - Missed another call site in project-chip#35148
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
…#35148) * [Darwin] Enable taking assertion on MTRDeviceController - Added ability to take assertion on MTRDeviceController to keep it running until all assertions are removed - A request to shutdown will take place only if there are no assertions are present * Fixed format string * Account for existing controller that is asserted in factory when creating a new one * Simplified to use lock for assertion tracking * Fixed build error * Removed unneeded includes * Fixed bugs with wrong match logic * resytle fixes * Restyle fixes * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Fixed build failure from review suggestions and added comment per review feedback --------- Co-authored-by: Boris Zbarsky <[email protected]>
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
… fabric as well (project-chip#35205) - Missed another call site in project-chip#35148
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
… fabric as well (project-chip#35205) - Missed another call site in project-chip#35148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.