Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup: we should probably think about what to do if the new thing has a different NOC than the old thing (e.g. changed CATs)... Right now we will just ignore that and keep using the old NOC. #35184

Open
anush-apple opened this issue Aug 23, 2024 · 1 comment
Assignees

Comments

@anush-apple
Copy link
Contributor

          Followup: we should probably think about what to do if the new thing has a different NOC than the old thing (e.g. changed CATs)...  Right now we will just ignore that and keep using the old NOC.

Similar for the various delegates that can get passed in via MTRDeviceControllerParameters. If they all match what we had before, this is fine, but if not, I think the caller can get into a pretty weird state where notifications are not being delivered where they expect them to be.

Longer-term: can we "swap" which object is being targeted by the XPC channel? If we can, it might be better to take down the old controller, bring up the new controller, and re-target what object XPC will hit....

Originally posted by @bzbarsky-apple in #35148 (comment)

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale Stale issue or PR label Sep 23, 2024
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants