Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup: we should consider using self.nodeID for the controllerNodeID getter, though then we should think about whether to set it nil on shutdown. Separate PR. #35183

Open
anush-apple opened this issue Aug 23, 2024 · 1 comment
Open

Followup: we should consider using self.nodeID for the controllerNodeID getter, though then we should think about whether to set it nil on shutdown. Separate PR. #35183

anush-apple opened this issue Aug 23, 2024 · 1 comment
Assignees
@anush-apple

Comments

@anush-apple
Copy link
Contributor 

          Followup: we should consider using `self.nodeID` for the `controllerNodeID` getter, though then we should think about whether to set it nil on shutdown.  Separate PR.

Originally posted by @bzbarsky-apple in #35148 (comment)
@anush-apple anush-apple self-assigned this Aug 23, 2024
@anush-apple anush-apple mentioned this issue Aug 23, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale Stale issue or PR label Sep 23, 2024
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anush-apple anush-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anush-apple @bzbarsky-apple