Fix and enable Matter Casting automation CI check for commissioner-generated-passcode flow. #34178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerated-passcode flow.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
vivien-apple,
tcarmelveilleux,
tecimovic,
wiba-nordic,
tehampson,
woody-apple,
tima-q,
younghak-hwang,
tobiasgraf,
yufengwangca,
turon and
yunhanw-google
shaoltan-amazon
commented
Jul 3, 2024
|
PR #34178: Size comparison from f8a633e to 6c02db3 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sharadb-amazon
approved these changes
Jul 3, 2024
|
The test failure on the original version was usually an mDNS timeout, see e.g. https://github.com/project-chip/connectedhomeip/actions/runs/9749187740/job/26905811716 Is that what you fixed? I think it would be good to just re-run the CI job a few times to make sure it passes consistently. |
|
Hi @ksperling-apple, the timeout was because the test couldn't find the string So the fix was to update the string in the test script to match the latest string format in the source code. |
ksperling-apple
approved these changes
Jul 4, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…nerated-passcode flow. (project-chip#34178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34151
Problem
The commit with the CI check for the commissioner-generated-passcode was reverted as it was consistently failing after being merged in.
Solution
Fixed the string that was causing the error.
Testing
scripts/examples/gn_build_example.sh examples/tv-app/linux/ out/tv-appscripts/examples/gn_build_example.sh examples/tv-casting-app/linux/ out/tv-casting-app chip_casting_simplified=truepython3 ./scripts/tests/run_tv_casting_test.pypython3 ./scripts/tests/run_tv_casting_test.py --commissioner-generated-passcode=True