-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app updated APIs.md docs with new v1.3 Matter APIs #34093
Merged
mergify
merged 4 commits into
project-chip:master
from
pgregorr-amazon:iosDroidLinux-docs-2024-06-24
Jul 1, 2024
Merged
tv-casting-app updated APIs.md docs with new v1.3 Matter APIs #34093
mergify
merged 4 commits into
project-chip:master
from
pgregorr-amazon:iosDroidLinux-docs-2024-06-24
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
June 27, 2024 00:27
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
June 27, 2024 00:27
PR #34093: Size comparison from 2908685 to ab075f7 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sharadb-amazon
requested changes
Jun 27, 2024
...es/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/support/TargetAppInfo.java
Outdated
Show resolved
Hide resolved
...es/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/support/TargetAppInfo.java
Outdated
Show resolved
Hide resolved
...ndroid/App/app/src/main/jni/com/matter/casting/support/IdentificationDeclarationOptions.java
Outdated
Show resolved
Hide resolved
PR #34093: Size comparison from 2908685 to 556f039 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sharadb-amazon
approved these changes
Jun 28, 2024
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
...ndroid/App/app/src/main/jni/com/matter/casting/support/IdentificationDeclarationOptions.java
Outdated
Show resolved
Hide resolved
pgregorr-amazon
force-pushed
the
iosDroidLinux-docs-2024-06-24
branch
from
June 28, 2024 20:54
c7d38fb
to
c0bc80e
Compare
PR #34093: Size comparison from 28430f1 to c0bc80e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chrisdecenzo
approved these changes
Jun 30, 2024
...s/tv-casting-app/android/App/app/src/main/java/com/matter/casting/InitializationExample.java
Show resolved
Hide resolved
hawk248
approved these changes
Jul 1, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…ct-chip#34093) * tv-casting-app updated APIs.md docs with new v1.3 Matter APIs * Fixing spelling error * Addressed comments by sharadb-amazon * Addressed comments by sharadb-amazon2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux, Android and iOS tv-casting-app example app, updated APIs.md with the new Matter v1.3 Matter Casting User Directed Commissioning (UDC) feature Commissioner-Generated Passcode feature commissioning flow APIs.
Change summary
Testing
Verified and tested locally with the Linux, Android and iOS tv-casting-app example mobile apps, and the Linux tv-app (CastingPlayer). Able to build and commission with the example apps.