Add test logic to Matter Casting Automation test script for commissioner-generated-passcode flow. #34079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner-generated-passcode flow.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
sharadb-amazon
approved these changes
Jun 25, 2024
|
PR #34079: Size comparison from 857accf to b44a595 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chrisdecenzo
approved these changes
Jun 26, 2024
yufengwangca
approved these changes
Jul 1, 2024
ksperling-apple
added a commit
to ksperling-apple/connectedhomeip
that referenced
this pull request
Jul 2, 2024
…ommissioner-generated-passcode flow. (project-chip#34079)" This reverts commit 176896a. "Test TV Casting Example / Linux Test" has been failing in master and all PRs since this landed. See https://github.com/project-chip/connectedhomeip/actions/workflows/examples-linux-tv-casting-app.yaml
ksperling-apple
added a commit
that referenced
this pull request
Jul 2, 2024
…ommissioner-generated-passcode flow. (#34079)" (#34151) This reverts commit 176896a. "Test TV Casting Example / Linux Test" has been failing in master and all PRs since this landed. See https://github.com/project-chip/connectedhomeip/actions/workflows/examples-linux-tv-casting-app.yaml
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…ner-generated-passcode flow. (project-chip#34079)
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…ommissioner-generated-passcode flow. (project-chip#34079)" (project-chip#34151) This reverts commit 176896a. "Test TV Casting Example / Linux Test" has been failing in master and all PRs since this landed. See https://github.com/project-chip/connectedhomeip/actions/workflows/examples-linux-tv-casting-app.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no automated testing available for the commissioner-generated-passcode flow in the Matter Casting automation test script as it currently only works for the commissionee-generated-passcode flow. We want to add this new test sequence and enable it to run as part of the CI checks to ensure that the casting experience continues to work between the Linux tv-casting-app and the Linux tv-app whenever a PR is raised.
Solution
Add a new test sequence to the
tv_casting_test_sequences.pyfile for the commissioner-generated-passcode flow along with the code needed to enable this test on the CI check by making changes to therun_tv_casting_test.pyand theexamples-linux-tv-casting-app.yamlfiles. Note, the default commissionee-generated-passcode test flow should still work as expected.Testing
python3 ./scripts/tests/run_tv_casting_test.py --commissioner-generated-passcode=Truepython3 ./scripts/tests/run_tv_casting_test.py