-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dns-sd] Added Operational Discovery and made browse delegate common #32750
Merged
mergify
merged 9 commits into
project-chip:master
from
su-shanka:feature/mDNS-operational-browse
May 9, 2024
Merged
[Dns-sd] Added Operational Discovery and made browse delegate common #32750
mergify
merged 9 commits into
project-chip:master
from
su-shanka:feature/mDNS-operational-browse
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
March 27, 2024 12:35
PR #32750: Size comparison from f6b3594 to 9287a60 Increases (36 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (52 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, linux, nrfconnect, nxp, qpg, stm32, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 3, 2024
su-shanka
force-pushed
the
feature/mDNS-operational-browse
branch
2 times, most recently
from
May 8, 2024 12:59
a933c0a
to
c43a1e5
Compare
Damian-Nordic
approved these changes
May 8, 2024
PR #32750: Size comparison from e887e58 to c43a1e5 Increases (48 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (27 builds for bl602, bl702, cc13x4_26x4, linux, nrfconnect, qpg, telink)
Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
su-shanka
force-pushed
the
feature/mDNS-operational-browse
branch
from
May 8, 2024 14:44
c43a1e5
to
0d329dc
Compare
PR #32750: Size comparison from 8edcecd to 0d329dc Increases (51 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (27 builds for bl602, bl702, cc13x4_26x4, linux, nrfconnect, qpg, telink)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 9, 2024
su-shanka
added a commit
to SiliconLabs/matter-for-unify
that referenced
this pull request
May 30, 2024
…roject-chip#32750) * Added operational discovery support * Restyled by whitespace * Restyled by clang-format * Updates as per review feedback * Restyled by whitespace * Restyled by clang-format * Updates based on additional feedback * Restyled by whitespace * updates as per feedback from review --------- Co-authored-by: Restyled.io <[email protected]>
su-shanka
added a commit
to SiliconLabs/matter-for-unify
that referenced
this pull request
May 30, 2024
…roject-chip#32750) * Added operational discovery support * Restyled by whitespace * Restyled by clang-format * Updates as per review feedback * Restyled by whitespace * Restyled by clang-format * Updates based on additional feedback * Restyled by whitespace * updates as per feedback from review --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for operational node browse/discovery. Also, updated existing browse/discover interface in Resolver class to a common interface for all types of node browse and made the delegates common for all browse(commissionable, commissioner and operational)
This is continuation of work in #26718.