Skip to content

Commit

Permalink
Fix all-clusters-app ZAP extension bits. (#21844)
Browse files Browse the repository at this point in the history
As part of PR #21494 the zcl-properties for all-clusters-app got
changed to the same one as for all the other example apps.  But this
one is supposed to have the with-extensions version, and have the
extension attribute on mode select enabled.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Nov 4, 2022
1 parent 9a7bf8c commit 4243235
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 47 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1770,6 +1770,7 @@ server cluster ModeSelect = 80 {
readonly attribute attrib_id attributeList[] = 65531;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;
readonly attribute int8u manufacturerExtension = 4293984257;

request struct ChangeToModeRequest {
INT8U newMode = 0;
Expand Down Expand Up @@ -4287,6 +4288,7 @@ endpoint 1 {
callback attribute attributeList;
ram attribute featureMap default = 1;
ram attribute clusterRevision default = 1;
ram attribute manufacturerExtension default = 255;
}

server cluster DoorLock {
Expand Down
29 changes: 23 additions & 6 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 77,
"featureLevel": 80,
"creator": "zap",
"keyValuePairs": [
{
Expand All @@ -18,11 +18,11 @@
"package": [
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/zcl/zcl.json",
"path": "../../../src/app/zap-templates/zcl/zcl-with-test-extensions.json",
"type": "zcl-properties",
"category": "matter",
"version": 1,
"description": "Matter SDK ZCL data"
"description": "Matter SDK ZCL data with some extensions"
},
{
"pathRelativity": "relativeToZap",
Expand Down Expand Up @@ -4673,7 +4673,7 @@
"reportableChange": 0
},
{
"name": "delay",
"name": "Delay",
"code": 58,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -4705,7 +4705,7 @@
"reportableChange": 0
},
{
"name": "ChannelMask",
"name": "ChannelPage0Mask",
"code": 60,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -12421,6 +12421,22 @@
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "ManufacturerExtension",
"code": 4293984257,
"mfgCode": null,
"side": "server",
"type": "int8u",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "255",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
}
]
},
Expand Down Expand Up @@ -24558,5 +24574,6 @@
"endpointVersion": 1,
"deviceIdentifier": 61442
}
]
],
"log": []
}
Loading

0 comments on commit 4243235

Please sign in to comment.