-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Fix the build with pregenerated files #27654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 6, 2023 10:40
PR #27654: Size comparison from ffc026f to be100e6 Increases (4 builds for bl702, cc32xx, cyw30739, psoc6)
Decreases (5 builds for bl702, esp32, psoc6)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
shubhamdp
force-pushed
the
fix_build_with_pregen
branch
from
July 6, 2023 12:15
be100e6
to
4f62736
Compare
dhrishi
approved these changes
Jul 6, 2023
PR #27654: Size comparison from ffc026f to 4f62736 Increases above 0.2%:
Increases (17 builds for bl702, bl702l, cc32xx, esp32, k32w, linux, psoc6, telink)
Decreases (12 builds for bl602, esp32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jul 6, 2023
shubhamdp
force-pushed
the
fix_build_with_pregen
branch
from
July 7, 2023 09:22
4f62736
to
1e40958
Compare
PR #27654: Size comparison from 19deed2 to 1e40958 Increases (12 builds for bl602, bl702, cyw30739, esp32, nrfconnect, telink)
Decreases (8 builds for bl702l, k32w, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
force-pushed
the
fix_build_with_pregen
branch
from
July 8, 2023 04:42
1e40958
to
bef05d2
Compare
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
July 8, 2023 04:43
PR #27654: Size comparison from 4fc5866 to bef05d2 Increases (11 builds for bl602, cc32xx, cyw30739, psoc6, qpg, telink)
Decreases (10 builds for bl702, bl702l, cyw30739, efr32, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#27636
Change Overview
Fixes #27636
Do not use --fail-on-unused-args flag when using pregenerated file
Tests