Skip to content

Commit

Permalink
Upload framework build logs on failure in darwin-tests job. (#27680)
Browse files Browse the repository at this point in the history
This way if building darwin-framework-tool fails we will know why.
  • Loading branch information
bzbarsky-apple authored Jul 7, 2023
1 parent 53e06c7 commit 19deed2
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions .github/workflows/darwin-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
uses: ./.github/actions/checkout-submodules-and-bootstrap
with:
platform: darwin
bootstrap-log-name: bootstrap-logs-darwin-${{ matrix.build_variant }}${{ matrix.chip_tool }}
bootstrap-log-name: bootstrap-logs-darwin-${{ matrix.build_variant }}

- name: Run macOS Darwin Framework Tool Build Debug
working-directory: src/darwin/Framework
Expand Down Expand Up @@ -126,21 +126,27 @@ jobs:
uses: actions/upload-artifact@v3
if: ${{ failure() && !env.ACT }}
with:
name: crash-core-darwin-${{ matrix.build_variant }}${{ matrix.chip_tool }}
name: crash-core-darwin-${{ matrix.build_variant }}
path: /cores/
# Cores are big; don't hold on to them too long.
retention-days: 5
- name: Uploading diagnostic logs
uses: actions/upload-artifact@v3
if: ${{ failure() && !env.ACT }}
with:
name: crash-log-darwin-${{ matrix.build_variant }}${{ matrix.chip_tool }}
name: crash-log-darwin-${{ matrix.build_variant }}
path: ~/Library/Logs/DiagnosticReports/
- name: Uploading framework build log
uses: actions/upload-artifact@v3
if: ${{ failure() && !env.ACT }}
with:
name: framework-build-log-darwin-${{ matrix.build_variant }}
path: out/darwin-x64-darwin-framework-tool-${{ matrix.build_variant }}/darwin_framework_build.log
- name: Uploading objdir for debugging
uses: actions/upload-artifact@v3
if: ${{ failure() && !env.ACT }}
with:
name: crash-objdir-darwin-${{ matrix.build_variant }}${{ matrix.chip_tool }}
name: crash-objdir-darwin-${{ matrix.build_variant }}
path: objdir-clone/
# objdirs are big; don't hold on to them too long.
retention-days: 5

0 comments on commit 19deed2

Please sign in to comment.