Skip to content

Commit

Permalink
Align naming in Application Basic cluster XML with the spec. (#24602)
Browse files Browse the repository at this point in the history
* Align naming in Application Basic cluster XML with the spec.

* Auto-update ZAP files.

* Regenerate generated code.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Nov 15, 2023
1 parent 9dce8aa commit 1919717
Show file tree
Hide file tree
Showing 42 changed files with 406 additions and 505 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16819,7 +16819,7 @@
"reportableChange": 0
},
{
"name": "IntrinsicBalanceFactor",
"name": "IntrinsicBallastFactor",
"code": 20,
"mfgCode": null,
"side": "server",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ struct LabelStruct {
char_string<16> value = 1;
}

struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

server cluster Identify = 3 {
enum IdentifyEffectIdentifier : ENUM8 {
kBlink = 0;
Expand Down Expand Up @@ -2928,11 +2933,6 @@ server cluster ApplicationLauncher = 1292 {
kApplicationPlatform = 0x1;
}

struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

Expand Down Expand Up @@ -2967,13 +2967,8 @@ server cluster ApplicationBasic = 1293 {
kActiveVisibleNotFocus = 3;
}

struct ApplicationBasicApplication {
int16u catalogVendorId = 0;
char_string applicationId = 1;
}

readonly attribute char_string<32> applicationName = 2;
readonly attribute ApplicationBasicApplication application = 4;
readonly attribute ApplicationStruct application = 4;
readonly attribute ApplicationStatusEnum status = 5;
readonly attribute char_string<32> applicationVersion = 6;
readonly attribute vendor_id allowedVendorList[] = 7;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16311,7 +16311,7 @@
"reportableChange": 0
},
{
"name": "IntrinsicBalanceFactor",
"name": "IntrinsicBallastFactor",
"code": 20,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -16461,7 +16461,7 @@
"side": "server",
"type": "array",
"included": 1,
"storageOption": "RAM",
"storageOption": "External",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
Expand All @@ -16477,7 +16477,7 @@
"side": "server",
"type": "array",
"included": 1,
"storageOption": "RAM",
"storageOption": "External",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
Expand All @@ -16493,7 +16493,7 @@
"side": "server",
"type": "array",
"included": 1,
"storageOption": "RAM",
"storageOption": "External",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
Expand Down Expand Up @@ -18865,7 +18865,7 @@
"code": 4,
"mfgCode": null,
"side": "server",
"type": "ApplicationBasicApplication",
"type": "ApplicationStruct",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down
16 changes: 8 additions & 8 deletions examples/placeholder/linux/apps/app1/config.matter
Original file line number Diff line number Diff line change
Expand Up @@ -2692,16 +2692,16 @@ client cluster ApplicationBasic = 1293 {
kActiveVisibleNotFocus = 3;
}

struct ApplicationBasicApplication {
int16u catalogVendorId = 0;
char_string applicationId = 1;
struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

readonly attribute char_string<32> vendorName = 0;
readonly attribute vendor_id vendorID = 1;
readonly attribute char_string<32> applicationName = 2;
readonly attribute int16u productID = 3;
readonly attribute ApplicationBasicApplication application = 4;
readonly attribute ApplicationStruct application = 4;
readonly attribute ApplicationStatusEnum status = 5;
readonly attribute char_string<32> applicationVersion = 6;
readonly attribute vendor_id allowedVendorList[] = 7;
Expand All @@ -2720,16 +2720,16 @@ server cluster ApplicationBasic = 1293 {
kActiveVisibleNotFocus = 3;
}

struct ApplicationBasicApplication {
int16u catalogVendorId = 0;
char_string applicationId = 1;
struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

readonly attribute char_string<32> vendorName = 0;
readonly attribute vendor_id vendorID = 1;
readonly attribute char_string<32> applicationName = 2;
readonly attribute int16u productID = 3;
readonly attribute ApplicationBasicApplication application = 4;
readonly attribute ApplicationStruct application = 4;
readonly attribute ApplicationStatusEnum status = 5;
readonly attribute char_string<32> applicationVersion = 6;
readonly attribute vendor_id allowedVendorList[] = 7;
Expand Down
2 changes: 1 addition & 1 deletion examples/placeholder/linux/apps/app1/config.zap
Original file line number Diff line number Diff line change
Expand Up @@ -6683,7 +6683,7 @@
"code": 4,
"mfgCode": null,
"side": "server",
"type": "ApplicationBasicApplication",
"type": "ApplicationStruct",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down
16 changes: 8 additions & 8 deletions examples/placeholder/linux/apps/app2/config.matter
Original file line number Diff line number Diff line change
Expand Up @@ -2669,16 +2669,16 @@ client cluster ApplicationBasic = 1293 {
kActiveVisibleNotFocus = 3;
}

struct ApplicationBasicApplication {
int16u catalogVendorId = 0;
char_string applicationId = 1;
struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

readonly attribute char_string<32> vendorName = 0;
readonly attribute vendor_id vendorID = 1;
readonly attribute char_string<32> applicationName = 2;
readonly attribute int16u productID = 3;
readonly attribute ApplicationBasicApplication application = 4;
readonly attribute ApplicationStruct application = 4;
readonly attribute ApplicationStatusEnum status = 5;
readonly attribute char_string<32> applicationVersion = 6;
readonly attribute vendor_id allowedVendorList[] = 7;
Expand All @@ -2697,16 +2697,16 @@ server cluster ApplicationBasic = 1293 {
kActiveVisibleNotFocus = 3;
}

struct ApplicationBasicApplication {
int16u catalogVendorId = 0;
char_string applicationId = 1;
struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

readonly attribute char_string<32> vendorName = 0;
readonly attribute vendor_id vendorID = 1;
readonly attribute char_string<32> applicationName = 2;
readonly attribute int16u productID = 3;
readonly attribute ApplicationBasicApplication application = 4;
readonly attribute ApplicationStruct application = 4;
readonly attribute ApplicationStatusEnum status = 5;
readonly attribute char_string<32> applicationVersion = 6;
readonly attribute vendor_id allowedVendorList[] = 7;
Expand Down
2 changes: 1 addition & 1 deletion examples/placeholder/linux/apps/app2/config.zap
Original file line number Diff line number Diff line change
Expand Up @@ -6967,7 +6967,7 @@
"code": 4,
"mfgCode": null,
"side": "server",
"type": "ApplicationBasicApplication",
"type": "ApplicationStruct",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down
17 changes: 6 additions & 11 deletions examples/tv-app/tv-common/tv-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ struct LabelStruct {
char_string<16> value = 1;
}

struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

server cluster OnOff = 6 {
enum OnOffDelayedAllOffEffectVariant : ENUM8 {
kFadeToOffIn0p8Seconds = 0;
Expand Down Expand Up @@ -2055,11 +2060,6 @@ server cluster ApplicationLauncher = 1292 {
optional endpoint_no endpoint = 1;
}

struct ApplicationStruct {
int16u catalogVendorID = 0;
char_string applicationID = 1;
}

readonly attribute INT16U catalogList[] = 0;
attribute nullable ApplicationEPStruct currentApp = 1;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -2099,16 +2099,11 @@ server cluster ApplicationBasic = 1293 {
kActiveVisibleNotFocus = 3;
}

struct ApplicationBasicApplication {
int16u catalogVendorId = 0;
char_string applicationId = 1;
}

readonly attribute char_string<32> vendorName = 0;
readonly attribute vendor_id vendorID = 1;
readonly attribute char_string<32> applicationName = 2;
readonly attribute int16u productID = 3;
readonly attribute ApplicationBasicApplication application = 4;
readonly attribute ApplicationStruct application = 4;
readonly attribute ApplicationStatusEnum status = 5;
readonly attribute char_string<32> applicationVersion = 6;
readonly attribute vendor_id allowedVendorList[] = 7;
Expand Down
2 changes: 1 addition & 1 deletion examples/tv-app/tv-common/tv-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -12063,7 +12063,7 @@
"code": 4,
"mfgCode": null,
"side": "server",
"type": "ApplicationBasicApplication",
"type": "ApplicationStruct",
"included": 1,
"storageOption": "External",
"singleton": 0,
Expand Down
Loading

0 comments on commit 1919717

Please sign in to comment.