-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Darwin availability annotations for Mode Select: #27113
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:mode-select-availability
Jun 7, 2023
Merged
Update Darwin availability annotations for Mode Select: #27113
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:mode-select-availability
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27113: Size comparison from 1793a4c to b40f75b Increases (11 builds for bl602, bl702, cc32xx, k32w, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, cyw30739, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
mode-select-availability
branch
from
June 7, 2023 01:45
b40f75b
to
2f41f30
Compare
PR #27113: Size comparison from 2520f47 to 2f41f30 Increases (9 builds for bl602, bl702, cc32xx, esp32, telink)
Decreases (6 builds for cyw30739, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jun 7, 2023
bzbarsky-apple
force-pushed
the
mode-select-availability
branch
from
June 7, 2023 03:31
2f41f30
to
4488d8b
Compare
PR #27113: Size comparison from 2520f47 to 4488d8b Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
force-pushed
the
mode-select-availability
branch
from
June 7, 2023 03:51
4488d8b
to
bb493e0
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
June 7, 2023 03:52
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
June 7, 2023 03:52
PR #27113: Size comparison from 2520f47 to bb493e0 Increases (10 builds for bl602, esp32, psoc6, telink)
Decreases (9 builds for bl702, cyw30739, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
vivien-apple
reviewed
Jun 7, 2023
vivien-apple
approved these changes
Jun 7, 2023
PR #27113: Size comparison from 2520f47 to 613a4fe Increases (3 builds for cc32xx, esp32, psoc6)
Decreases (3 builds for cyw30739, psoc6, qpg)
Full report (38 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
|
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
Co-authored-by: Vivien Nicolas <[email protected]>
bzbarsky-apple
force-pushed
the
mode-select-availability
branch
from
June 7, 2023 16:09
613a4fe
to
20f0f51
Compare
PR #27113: Size comparison from 42b424d to 20f0f51 Increases (8 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, psoc6, qpg, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27085 (with the first item in there fixed in #27088).