Mark various appliance mode select clusters provisional in Darwin codegen. #27088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
|
PR #27088: Size comparison from 9828293 to 1949556 Increases (5 builds for bl602, cc32xx, k32w, psoc6)
Decreases (2 builds for bl702, psoc6)
Full report (40 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
andy31415
approved these changes
Jun 5, 2023
bzbarsky-apple
force-pushed
the
provisional-mode-selects
branch
from
1949556 to
32aa753
Compare
|
PR #27088: Size comparison from f701c45 to 32aa753 Increases (8 builds for bl602, cc32xx, cyw30739, esp32, nrfconnect, telink)
Decreases (13 builds for bl702, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 6, 2023
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 6, 2023
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
…egen. We're still sorting out questions around Mode Select shape, so would rather not expose the new APIs until they're more stable.
bzbarsky-apple
force-pushed
the
provisional-mode-selects
branch
from
32aa753 to
0f285ae
Compare
|
PR #27088: Size comparison from a73c8e9 to 0f285ae Increases (9 builds for bl602, psoc6, telink)
Decreases (7 builds for bl702, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
anush-apple
approved these changes
Jun 6, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 6, 2023
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 7, 2023
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 7, 2023
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 7, 2023
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 7, 2023
* Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes project-chip#27085 (with the first item in there fixed in project-chip#27088).
bzbarsky-apple
added a commit
that referenced
this pull request
Jun 7, 2023
* Update Darwin availability annotations for Mode Select: * Marks the new commands and associated feature provisional, because those changes might not in fact happen to Mode Select. * Marks the new tagName field of ModeTagStruct as provisional, for the same reason. * Marks the new enums provisional, for the same reason. * Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we directly renamed SemanticTag to ModeTagStruct and then adding a manual SemanticTagStruct shim. * Handles the renames of the OnOff feature and the ModeTags field of the ModeOptionsStruct. Fixes #27085 (with the first item in there fixed in #27088). * Fix typos per code review. Co-authored-by: Vivien Nicolas <[email protected]> --------- Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still sorting out questions around Mode Select shape, so would rather not expose the new APIs until they're more stable.