Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to update Darwin availability annotations for Mode Select bits #27085

Closed
bzbarsky-apple opened this issue Jun 5, 2023 · 0 comments · Fixed by #27113
Closed

Need to update Darwin availability annotations for Mode Select bits #27085

bzbarsky-apple opened this issue Jun 5, 2023 · 0 comments · Fixed by #27113
Assignees
@bzbarsky-apple
Labels
darwin v1.2

Comments

@bzbarsky-apple
Copy link
Contributor

In #26508 the following changes happened:

  1. Add a bunch of new Mode Select aliases/derived-clusters. We should just mark them all provisional in the Darwin codegen until things stabilize.
  2. Add StatusCode enum for ModeSelect. This just needs to be added to availability annotations.
  3. Add a ModeTag enum. This just needs to be added to availability annotations.
  4. Rename SemanticTagStruct to ModeTagStruct. This is a problem, because we renamed this struct once already, from SemanticTag. Probably the right thing to do is to claim that ModeTagStruct used to be called SemanticTag, and add a manual shim definition for SemanticTagStruct.
  5. A TagName field was added to ModeTagStruct.
  6. The SemanticTags field of ModeOptionsStruct got renamed to ModeTags.
  7. A ChangeToModeWithStatus command was added, with a NewMode field.
  8. A ChangeToModeResponse command was added, with Status and StatusText fields.
  9. The DEPONOFF feature was renamed to OnOff
  10. An ExtendedStatus feature was added.
@bzbarsky-apple bzbarsky-apple self-assigned this Jun 5, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 6, 2023
@bzbarsky-apple
Update Darwin availability annotations for Mode Select:
6967601 
* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes project-chip#27085 (with the
first item in there fixed in project-chip#27088).
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 6, 2023
@bzbarsky-apple
Update Darwin availability annotations for Mode Select:
14e6a83 
* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes project-chip#27085 (with the
first item in there fixed in project-chip#27088).
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 6, 2023
@bzbarsky-apple
Update Darwin availability annotations for Mode Select:
b40f75b 
* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes project-chip#27085 (with the
first item in there fixed in project-chip#27088).
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 6, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 7, 2023
@bzbarsky-apple
Update Darwin availability annotations for Mode Select:
2f41f30 
* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes project-chip#27085 (with the
first item in there fixed in project-chip#27088).
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 7, 2023
@bzbarsky-apple
Update Darwin availability annotations for Mode Select:
4488d8b 
* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes project-chip#27085 (with the
first item in there fixed in project-chip#27088).
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 7, 2023
@bzbarsky-apple
Update Darwin availability annotations for Mode Select:
bb493e0 
* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes project-chip#27085 (with the
first item in there fixed in project-chip#27088).
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 7, 2023
@bzbarsky-apple
Update Darwin availability annotations for Mode Select:
38835d1 
* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes project-chip#27085 (with the
first item in there fixed in project-chip#27088).
bzbarsky-apple added a commit that referenced this issue Jun 7, 2023
@bzbarsky-apple @vivien-apple
Update Darwin availability annotations for Mode Select: (#27113)
2778b13 
* Update Darwin availability annotations for Mode Select:

* Marks the new commands and associated feature provisional, because those
  changes might not in fact happen to Mode Select.
* Marks the new tagName field of ModeTagStruct as provisional, for the same
  reason.
* Marks the new enums provisional, for the same reason.
* Handles the rename of SemanticTagStruct to ModeTagStruct by pretending that we
  directly renamed SemanticTag to ModeTagStruct and then adding a manual
  SemanticTagStruct shim.
* Handles the renames of the OnOff feature and the ModeTags field of the
  ModeOptionsStruct.

Fixes #27085 (with the
first item in there fixed in #27088).

* Fix typos per code review.

Co-authored-by: Vivien Nicolas <[email protected]>

---------

Co-authored-by: Vivien Nicolas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Darwin availability annotations for Mode Select: bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple