-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XML and zap gen for dishwasher alarm cluster #26771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
May 23, 2023 20:25
PR #26771: Size comparison from bf95967 to b5f2e09 Increases above 0.2%:
Increases (23 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (5 builds for efr32, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Jun 13, 2023
PR #26771: Size comparison from ecd0f6f to 7a30871 Increases above 0.2%:
Increases (26 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, psoc6, qpg, telink)
Decreases (8 builds for bl602, bl702, esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
reviewed
Jun 15, 2023
jmeg-sfy
reviewed
Jun 15, 2023
PR #26771: Size comparison from 3be88f8 to 3d503f3 Increases above 0.2%:
Increases (27 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 16, 2023
mideayanghui
approved these changes
Jun 18, 2023
jmeg-sfy
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
appliances
Stuff related to appliance types and clusters
controller
darwin
github
review - approved
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the XML and zap gen for the new dishwasher alarm cluster.
See this PR for details of the added cluster and associated impact: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7070
See the following PRs which addressed changes in the alarm base and dish alarm spec:
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7196
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7200