Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISHALM] Change SDK for dishwasher alarm spec change #27257

Closed
rbultman opened this issue Jun 14, 2023 · 1 comment
Closed

[DISHALM] Change SDK for dishwasher alarm spec change #27257

rbultman opened this issue Jun 14, 2023 · 1 comment
Labels
Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation

Comments

@rbultman
Copy link
Contributor

rbultman commented Jun 14, 2023 •
edited
Loading

See this PR which modifies alarm base: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7196
See this PR which modifies the dishwasher alarms cluster: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7200

A subsequent PR will change the dish spec itself.
@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation Spec XML align SDK XML does not match the spec (including naming, etc) labels Jun 15, 2023
@bzbarsky-apple
Copy link
Contributor

See this PR which modifies alarm base

"Supported" attribute was part of the initial dishwasher alarm landing in PR #26771.

See this PR which modifies the dishwasher alarms cluster

The lack of feature map was part of the same landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbultman @bzbarsky-apple