Skip to content

Commit

Permalink
Fix window covering XML and regen .zap files. (#11055)
Browse files Browse the repository at this point in the history
We had some changes to .xml files to rename things that were not reflected into .zap files.  Running ./scripts/tools/zap_convert_all.py fixes that, but fails before this PR because ZAP support for <tag> is broken and #9246 introduced use of <tag> in window-covering.xml.

So the changes:

1) Comment out the <tag> bits in
   src/app/zap-templates/zcl/data-model/chip/window-covering.xml.
2) Run ./scripts/tools/zap_convert_all.py to fix up the attribute names in
   the .zap files.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Jan 20, 2022
1 parent 4ab7944 commit 6003665
Show file tree
Hide file tree
Showing 17 changed files with 167 additions and 180 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18990,6 +18990,5 @@
"endpointVersion": null,
"deviceIdentifier": null
}
],
"log": []
]
}
3 changes: 1 addition & 2 deletions examples/bridge-app/bridge-common/bridge-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -4018,6 +4018,5 @@
"endpointVersion": null,
"deviceIdentifier": null
}
],
"log": []
]
}
3 changes: 1 addition & 2 deletions examples/lighting-app/lighting-common/lighting-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -6211,6 +6211,5 @@
"endpointVersion": 1,
"deviceIdentifier": 259
}
],
"log": []
]
}
3 changes: 1 addition & 2 deletions examples/lock-app/lock-common/lock-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -5022,6 +5022,5 @@
"endpointVersion": 0,
"deviceIdentifier": null
}
],
"log": []
]
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 54,
"featureLevel": 63,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3410,7 +3410,7 @@
"commands": [],
"attributes": [
{
"name": "measured value",
"name": "MeasuredValue",
"code": 0,
"mfgCode": null,
"side": "server",
Expand All @@ -3425,7 +3425,7 @@
"reportableChange": 0
},
{
"name": "min measured value",
"name": "MinMeasuredValue",
"code": 1,
"mfgCode": null,
"side": "server",
Expand All @@ -3440,7 +3440,7 @@
"reportableChange": 0
},
{
"name": "max measured value",
"name": "MaxMeasuredValue",
"code": 2,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3638,4 +3638,4 @@
"deviceIdentifier": null
}
]
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 62,
"featureLevel": 63,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -3434,7 +3434,7 @@
"commands": [],
"attributes": [
{
"name": "measured value",
"name": "MeasuredValue",
"code": 0,
"mfgCode": null,
"side": "server",
Expand All @@ -3449,7 +3449,7 @@
"reportableChange": 0
},
{
"name": "min measured value",
"name": "MinMeasuredValue",
"code": 1,
"mfgCode": null,
"side": "server",
Expand All @@ -3464,7 +3464,7 @@
"reportableChange": 0
},
{
"name": "max measured value",
"name": "MaxMeasuredValue",
"code": 2,
"mfgCode": null,
"side": "server",
Expand Down Expand Up @@ -3661,6 +3661,5 @@
"endpointVersion": 1,
"deviceIdentifier": 0
}
],
"log": []
]
}
7 changes: 3 additions & 4 deletions examples/placeholder/linux/apps/app1/config.zap
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"endpointTypes": [
{
"name": "Anonymous Endpoint Type",
"deviceTypeName": "Root Node Device Type",
"deviceTypeName": "Base Application Example",
"deviceTypeCode": 65280,
"deviceTypeProfileId": 259,
"clusters": [
Expand Down Expand Up @@ -1907,6 +1907,5 @@
"endpointVersion": 1,
"deviceIdentifier": 258
}
],
"log": []
}
]
}
7 changes: 3 additions & 4 deletions examples/placeholder/linux/apps/app2/config.zap
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"endpointTypes": [
{
"name": "Anonymous Endpoint Type",
"deviceTypeName": "Root Node Device Type",
"deviceTypeName": "Base Application Example",
"deviceTypeCode": 65280,
"deviceTypeProfileId": 259,
"clusters": [
Expand Down Expand Up @@ -1710,6 +1710,5 @@
"endpointVersion": 1,
"deviceIdentifier": 257
}
],
"log": []
}
]
}
Loading

0 comments on commit 6003665

Please sign in to comment.