Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window Covering: Add FeatureMap #9246

Merged
merged 15 commits into from
Oct 27, 2021
Merged

Window Covering: Add FeatureMap #9246

merged 15 commits into from
Oct 27, 2021

Conversation

jmeg-sfy
Copy link
Contributor

@jmeg-sfy jmeg-sfy commented Aug 25, 2021 •
edited
Loading

Change overview

This PR add the missing FeatureMap global attribute:

  • Into the controllers
  • In the WindowCovering examples -> EFR32 and all-cluster-app

This is also following this specs PR https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/3794

Testing

How was this tested? (at least one bullet point required)

  • Reading the global attribute Unit Test is now activated and passing CI

@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/window-covering-add-featuremap branch from 96db366 to a55036a Compare August 30, 2021 12:27
@jmeg-sfy jmeg-sfy linked an issue Aug 31, 2021 that may be closed by this pull request
Uncomment and fill properly once FEATURE MAP available #8506
Closed
@woody-apple
Copy link
Contributor

@jmeg-sfy Sorry conflicts here :(

@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/window-covering-add-featuremap branch from a55036a to 4218afa Compare September 1, 2021 11:40
@jmeg-sfy
Copy link
Contributor Author

jmeg-sfy commented Sep 1, 2021

@jmeg-sfy Sorry conflicts here :(

@woody-apple ToT rebased !

@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/window-covering-add-featuremap branch from 4218afa to 6467f70 Compare September 3, 2021 09:41
@jmeg-sfy
Copy link
Contributor Author

jmeg-sfy commented Sep 3, 2021

@woody-apple ToT rebased conflict fixed (again)

@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/window-covering-add-featuremap branch from 726422e to 257b4e6 Compare September 8, 2021 16:42
@woody-apple
Copy link
Contributor

@jmeg-sfy Can you resolve conflicts please?

@woody-apple
Copy link
Contributor

You're welcome to merge yourself FYI, once it builds and conflicts are resolved.

@restyled-io restyled-io bot mentioned this pull request Oct 27, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #9246: Size comparison from 4b1bc90 to 2996f40

Increases (6 builds for efr32, esp32, linux, mbed)
platform target config section 4b1bc90 2996f40 change % change
efr32 window-app BRD4161A (read only) 716676 716716 40 0.0
(read/write) 113576 113584 8 0.0
.bss 111860 111868 8 0.0
.text 716668 716708 40 0.0
esp32 all-clusters-app c3devkit (read/write) 1306128 1306144 16 0.0
.flash.rodata 198192 198208 16 0.0
m5stack (read/write) 425936 425968 32 0.0
.dram0.bss 60744 60752 8 0.0
.flash.rodata 206944 206968 24 0.0
linux all-clusters-app debug (read only) 1626393 1626417 24 0.0
(read/write) 117344 117408 64 0.1
.bss 50288 50320 32 0.1
.data.rel.ro 60832 60864 32 0.1
chip-tool debug (read only) 4117941 4120269 2328 0.1
(read/write) 119448 119512 64 0.1
.data.rel.ro 94784 94848 64 0.1
.rodata 208208 208336 128 0.1
.text 3653125 3655157 2032 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2289384 2289408 24 0.0
.bss 179604 179612 8 0.0
.text 1251984 1252008 24 0.0
Decreases (1 build for mbed)
platform target config section 4b1bc90 2996f40 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851648 851640 -8 -0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4b1bc90 2996f40 change % change
efr32 lighting-app BRD4161A (read only) 736512 736512 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 736504 736504 0 0.0
BRD4161A+rpc (read only) 723936 723936 0 0.0
(read/write) 132052 132052 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 723928 723928 0 0.0
lock-app BRD4161A (read only) 715792 715792 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 715784 715784 0 0.0
window-app BRD4161A (read only) 716676 716716 40 0.0
(read/write) 113576 113584 8 0.0
.bss 111860 111868 8 0.0
.data 1716 1716 0 0.0
.text 716668 716708 40 0.0
esp32 all-clusters-app c3devkit (read only) 875074 875074 0 0.0
(read/write) 1306128 1306144 16 0.0
.dram0.bss 58240 58240 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198192 198208 16 0.0
.flash.text 875074 875074 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906171 906171 0 0.0
(read/write) 425936 425968 32 0.0
.dram0.bss 60744 60752 8 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206944 206968 24 0.0
.flash.text 906171 906171 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 700600 700600 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614180 614180 0 0.0
lock-app k32w061+debug (read/write) 592404 592404 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515544 515544 0 0.0
shell k32w061+debug (read/write) 425204 425204 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
linux all-clusters-app debug (read only) 1626393 1626417 24 0.0
(read/write) 117344 117408 64 0.1
.bss 50288 50320 32 0.1
.data 978 978 0 0.0
.data.rel.ro 60832 60864 32 0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 134677 134677 0 0.0
.text 1360002 1360002 0 0.0
bridge-app debug+rpc (read only) 1271485 1271485 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109884 109884 0 0.0
.text 1066261 1066261 0 0.0
chip-tool debug (read only) 4117941 4120269 2328 0.1
(read/write) 119448 119512 64 0.1
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94784 94848 64 0.1
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 208208 208336 128 0.1
.text 3653125 3655157 2032 0.1
lighting-app debug+rpc (read only) 1523369 1523369 0 0.0
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127185 127185 0 0.0
.text 1264162 1264162 0 0.0
ota-provider-app debug (read only) 1232161 1232161 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110504 110504 0 0.0
.text 1025698 1025698 0 0.0
ota-requestor-app debug (read only) 1289297 1289297 0 0.0
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127392 127392 0 0.0
.text 1064306 1064306 0 0.0
shell debug (read only) 777097 777097 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76527 0 0.0
.text 599442 599442 0 0.0
tv-app debug (read only) 1750105 1750105 0 0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152184 152184 0 0.0
.text 1456210 1456210 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289384 2289408 24 0.0
.bss 179604 179612 8 0.0
.data 5192 5192 0 0.0
.heap 851648 851640 -8 -0.0
.text 1251984 1252008 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257072 2257072 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219672 1219672 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2235104 2235104 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1197704 1197704 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862471 862471 0 0.0
bss 112136 112136 0 0.0
rodata 97200 97200 0 0.0
text 577512 577512 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823311 823311 0 0.0
bss 108380 108380 0 0.0
rodata 87976 87976 0 0.0
text 550704 550704 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787510 787510 0 0.0
bss 113512 113512 0 0.0
rodata 92440 92440 0 0.0
text 506984 506984 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839415 839415 0 0.0
bss 111208 111208 0 0.0
rodata 93600 93600 0 0.0
text 559072 559072 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764458 764458 0 0.0
bss 112584 112584 0 0.0
rodata 88860 88860 0 0.0
text 488536 488536 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843815 843815 0 0.0
bss 111308 111308 0 0.0
rodata 94800 94800 0 0.0
text 562176 562176 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839135 839135 0 0.0
bss 111208 111208 0 0.0
rodata 93576 93576 0 0.0
text 558816 558816 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776531 776531 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691586 691586 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0
p6 lock-app default (read/write) 2168520 2168520 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1126784 1126784 0 0.0
qpg lighting-app qpg6100+debug (read only) 490760 490760 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485440 485440 0 0.0
lock-app qpg6100+debug (read only) 466980 466980 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 461660 461660 0 0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664066 664066 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 457976 457976 0 0.0

@restyled-io restyled-io bot mentioned this pull request Oct 27, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #9246: Size comparison from 9b8410f to 65dbbf9

Increases (16 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 9b8410f 65dbbf9 change % change
efr32 lighting-app BRD4161A (read only) 736480 737008 528 0.1
.text 736472 737000 528 0.1
BRD4161A+rpc (read only) 723912 724440 528 0.1
.text 723904 724432 528 0.1
window-app BRD4161A (read only) 717140 717180 40 0.0
(read/write) 113576 113584 8 0.0
.bss 111860 111868 8 0.0
.text 717132 717172 40 0.0
esp32 all-clusters-app c3devkit (read/write) 1306432 1306456 24 0.0
.flash.rodata 198496 198520 24 0.0
m5stack (read/write) 426240 426264 24 0.0
.dram0.bss 60744 60752 8 0.0
.flash.rodata 207248 207264 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 700792 701048 256 0.0
.text 614372 614628 256 0.0
linux all-clusters-app debug (read only) 1633241 1633265 24 0.0
(read/write) 117344 117408 64 0.1
.bss 50288 50320 32 0.1
.data.rel.ro 60832 60864 32 0.1
chip-tool debug (read only) 4135157 4137517 2360 0.1
(read/write) 119576 119640 64 0.1
.data.rel.ro 94912 94976 64 0.1
.rodata 209296 209456 160 0.1
.text 3668965 3670997 2032 0.1
lighting-app debug+rpc (read only) 1524201 1526265 2064 0.1
.text 1263298 1266354 3056 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288512 2288536 24 0.0
.bss 179604 179612 8 0.0
.text 1251112 1251136 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2255512 2255768 256 0.0
.text 1218112 1218368 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862647 862919 272 0.0
text 577388 577652 264 0.0
nrf52840dk_nrf52840+rpc (read/write) 823487 823759 272 0.0
text 550580 550844 264 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787686 787942 256 0.0
text 506860 507120 260 0.1
qpg lighting-app qpg6100+debug (read only) 490944 491216 272 0.1
.text 485624 485896 272 0.1
telink lighting-app tlsr9518adk80d (read/write) 664310 664614 304 0.0
text 457906 458210 304 0.1
Decreases (3 builds for esp32, linux, mbed)
platform target config section 9b8410f 65dbbf9 change % change
esp32 all-clusters-app m5stack (read only) 906903 906827 -76 -0.0
.flash.text 906903 906827 -76 -0.0
linux lighting-app debug+rpc (read/write) 101552 101520 -32 -0.0
.data.rel.ro 53984 53968 -16 -0.0
.rodata 128881 127889 -992 -0.8
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851648 851640 -8 -0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9b8410f 65dbbf9 change % change
efr32 lighting-app BRD4161A (read only) 736480 737008 528 0.1
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 736472 737000 528 0.1
BRD4161A+rpc (read only) 723912 724440 528 0.1
(read/write) 132052 132052 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 723904 724432 528 0.1
lock-app BRD4161A (read only) 716272 716272 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716264 716264 0 0.0
window-app BRD4161A (read only) 717140 717180 40 0.0
(read/write) 113576 113584 8 0.0
.bss 111860 111868 8 0.0
.data 1716 1716 0 0.0
.text 717132 717172 40 0.0
esp32 all-clusters-app c3devkit (read only) 875722 875722 0 0.0
(read/write) 1306432 1306456 24 0.0
.dram0.bss 58240 58240 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198496 198520 24 0.0
.flash.text 875722 875722 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906903 906827 -76 -0.0
(read/write) 426240 426264 24 0.0
.dram0.bss 60744 60752 8 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207248 207264 16 0.0
.flash.text 906903 906827 -76 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 700792 701048 256 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614372 614628 256 0.0
lock-app k32w061+debug (read/write) 592852 592852 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515992 515992 0 0.0
shell k32w061+debug (read/write) 425188 425188 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359556 359556 0 0.0
linux all-clusters-app debug (read only) 1633241 1633265 24 0.0
(read/write) 117344 117408 64 0.1
.bss 50288 50320 32 0.1
.data 978 978 0 0.0
.data.rel.ro 60832 60864 32 0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135541 0 0.0
.text 1365986 1365986 0 0.0
bridge-app debug+rpc (read only) 1274749 1274749 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110684 0 0.0
.text 1068725 1068725 0 0.0
chip-tool debug (read only) 4135157 4137517 2360 0.1
(read/write) 119576 119640 64 0.1
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94912 94976 64 0.1
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 209296 209456 160 0.1
.text 3668965 3670997 2032 0.1
lighting-app debug+rpc (read only) 1524201 1526265 2064 0.1
(read/write) 101552 101520 -32 -0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53984 53968 -16 -0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128881 127889 -992 -0.8
.text 1263298 1266354 3056 0.2
ota-provider-app debug (read only) 1233809 1233809 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110984 0 0.0
.text 1026866 1026866 0 0.0
ota-requestor-app debug (read only) 1291105 1291105 0 0.0
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127904 0 0.0
.text 1065602 1065602 0 0.0
shell debug (read only) 777705 777705 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76527 0 0.0
.text 600050 600050 0 0.0
tv-app debug (read only) 1752841 1752841 0 0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152984 0 0.0
.text 1458146 1458146 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288512 2288536 24 0.0
.bss 179604 179612 8 0.0
.data 5192 5192 0 0.0
.heap 851648 851640 -8 -0.0
.text 1251112 1251136 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255512 2255768 256 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218112 1218368 256 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233800 2233800 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196400 1196400 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862647 862919 272 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577388 577652 264 0.0
nrf52840dk_nrf52840+rpc (read/write) 823487 823759 272 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550580 550844 264 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787686 787942 256 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 506860 507120 260 0.1
lock-app nrf52840dk_nrf52840 (read/write) 839863 839863 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559208 559208 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764890 764890 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488672 488672 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844263 844263 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562316 562316 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839583 839583 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 558956 558956 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776531 776531 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691586 691586 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440932 440932 0 0.0
p6 lock-app default (read/write) 2169008 2169008 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127272 1127272 0 0.0
qpg lighting-app qpg6100+debug (read only) 490944 491216 272 0.1
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485624 485896 272 0.1
lock-app qpg6100+debug (read only) 467436 467436 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462116 462116 0 0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664310 664614 304 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 457906 458210 304 0.1

@github-actions
Copy link

PR #9246: Size comparison from 2149dae to dada6df

Full report (8 builds for k32w, p6, qpg, telink)
platform target config section 2149dae dada6df change % change
k32w lock-app k32w061+debug (read/write) 592900 592900 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516040 516040 0 0.0
shell k32w061+debug (read/write) 425236 425236 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359604 359604 0 0.0
lighting-app k32w061+se05x+release (read/write) 701096 701096 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614676 614676 0 0.0
p6 lock-app default (read/write) 2169088 2169088 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127352 1127352 0 0.0
qpg lighting-app qpg6100+debug (read only) 491264 491264 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485944 485944 0 0.0
lock-app qpg6100+debug (read only) 467484 467484 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462164 462164 0 0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664670 664670 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458270 458270 0 0.0

@woody-apple
Copy link
Contributor

/rebase

1 similar comment
@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple merged commit 1114959 into project-chip:master Oct 27, 2021
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #9246: Size comparison from 1d10ef8 to 3af5516

Increases (6 builds for efr32, esp32, linux, mbed)
platform target config section 1d10ef8 3af5516 change % change
efr32 window-app BRD4161A (read only) 717236 717276 40 0.0
(read/write) 113576 113584 8 0.0
.bss 111860 111868 8 0.0
.text 717228 717268 40 0.0
esp32 all-clusters-app c3devkit (read/write) 1306432 1306456 24 0.0
.flash.rodata 198496 198520 24 0.0
m5stack (read/write) 426240 426264 24 0.0
.dram0.bss 60744 60752 8 0.0
.flash.rodata 207248 207264 16 0.0
linux all-clusters-app debug (read only) 1634185 1634209 24 0.0
(read/write) 117344 117408 64 0.1
.bss 50288 50320 32 0.1
.data.rel.ro 60832 60864 32 0.1
chip-tool debug (read only) 4143965 4146325 2360 0.1
(read/write) 120120 120184 64 0.1
.data.rel.ro 95440 95520 80 0.1
.rodata 210064 210224 160 0.1
.text 3675781 3677813 2032 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288640 2288664 24 0.0
.bss 179604 179612 8 0.0
.text 1251240 1251264 24 0.0
Decreases (1 build for mbed)
platform target config section 1d10ef8 3af5516 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851648 851640 -8 -0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1d10ef8 3af5516 change % change
efr32 lighting-app BRD4161A (read only) 737104 737104 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737096 737096 0 0.0
BRD4161A+rpc (read only) 724536 724536 0 0.0
(read/write) 132052 132052 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724528 724528 0 0.0
lock-app BRD4161A (read only) 716368 716368 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716360 716360 0 0.0
window-app BRD4161A (read only) 717236 717276 40 0.0
(read/write) 113576 113584 8 0.0
.bss 111860 111868 8 0.0
.data 1716 1716 0 0.0
.text 717228 717268 40 0.0
esp32 all-clusters-app c3devkit (read only) 875790 875790 0 0.0
(read/write) 1306432 1306456 24 0.0
.dram0.bss 58240 58240 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198496 198520 24 0.0
.flash.text 875790 875790 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906891 906891 0 0.0
(read/write) 426240 426264 24 0.0
.dram0.bss 60744 60752 8 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207248 207264 16 0.0
.flash.text 906891 906891 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701096 701096 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614676 614676 0 0.0
lock-app k32w061+debug (read/write) 592900 592900 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516040 516040 0 0.0
shell k32w061+debug (read/write) 425236 425236 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359604 359604 0 0.0
linux all-clusters-app debug (read only) 1634185 1634209 24 0.0
(read/write) 117344 117408 64 0.1
.bss 50288 50320 32 0.1
.data 978 978 0 0.0
.data.rel.ro 60832 60864 32 0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135541 0 0.0
.text 1366930 1366930 0 0.0
bridge-app debug+rpc (read only) 1275693 1275693 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110684 0 0.0
.text 1069669 1069669 0 0.0
chip-tool debug (read only) 4143965 4146325 2360 0.1
(read/write) 120120 120184 64 0.1
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 95440 95520 80 0.1
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 210064 210224 160 0.1
.text 3675781 3677813 2032 0.1
lighting-app debug+rpc (read only) 1527209 1527209 0 0.0
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127889 127889 0 0.0
.text 1267298 1267298 0 0.0
ota-provider-app debug (read only) 1234753 1234753 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110984 0 0.0
.text 1027810 1027810 0 0.0
ota-requestor-app debug (read only) 1292033 1292033 0 0.0
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127904 0 0.0
.text 1066530 1066530 0 0.0
shell debug (read only) 778361 778361 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76527 0 0.0
.text 600706 600706 0 0.0
tv-app debug (read only) 1753753 1753753 0 0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152984 0 0.0
.text 1459058 1459058 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288640 2288664 24 0.0
.bss 179604 179612 8 0.0
.data 5192 5192 0 0.0
.heap 851648 851640 -8 -0.0
.text 1251240 1251264 24 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255896 2255896 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218496 1218496 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233928 2233928 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196528 1196528 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862967 862967 0 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577704 577704 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823807 0 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550896 550896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788006 788006 0 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507176 507176 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839911 839911 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559264 559264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764954 764954 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488728 488728 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844311 844311 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562368 562368 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839631 839631 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 559008 559008 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776579 776579 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520368 520368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691634 691634 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440980 440980 0 0.0
p6 lock-app default (read/write) 2169104 2169104 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127368 1127368 0 0.0
qpg lighting-app qpg6100+debug (read only) 491272 491272 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485952 485952 0 0.0
lock-app qpg6100+debug (read only) 467492 467492 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462172 462172 0 0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664678 664678 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458278 458278 0 0.0

@github-actions
Copy link

Size increase report for "esp32-example-build" from 1d10ef8

File Section File VM
chip-all-clusters-app.elf .flash.rodata 24 24
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.rodata,24,24
[Unmapped],0,-24
.debug_loc,0,-56

@jmeg-sfy
Copy link
Contributor Author

@woody-apple sorry i didnt see your comment earlier
thanks for doing it but the bug behind might not be close since it depend of ZAP

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 27, 2021
@bzbarsky-apple
Fix window covering XML and regen .zap files.
7ef6220 
We had some changes to .xml files to rename things that were not reflected into .zap files.  Running ./scripts/tools/zap_convert_all.py fixes that, but fails before this PR because ZAP support for <tag> is broken and project-chip#9246 introduced use of <tag> in window-covering.xml.

So the changes:

1) Comment out the <tag> bits in
   src/app/zap-templates/zcl/data-model/chip/window-covering.xml.
2) Run ./scripts/tools/zap_convert_all.py to fix up the attribute names in
   the .zap files.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Oct 27, 2021
Merged
andy31415 pushed a commit that referenced this pull request Oct 27, 2021
@bzbarsky-apple
Fix window covering XML and regen .zap files. (#11055)
9a618bb 
We had some changes to .xml files to rename things that were not reflected into .zap files.  Running ./scripts/tools/zap_convert_all.py fixes that, but fails before this PR because ZAP support for <tag> is broken and #9246 introduced use of <tag> in window-covering.xml.

So the changes:

1) Comment out the <tag> bits in
   src/app/zap-templates/zcl/data-model/chip/window-covering.xml.
2) Run ./scripts/tools/zap_convert_all.py to fix up the attribute names in
   the .zap files.
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@jmeg-sfy @woody-apple
@restyled-commits @JasonLiuZhuoCheng
Window Covering: Add FeatureMap (project-chip#9246)
ec322fb 
* WC: Add FeatureMap inside xml + zap

* WC: Update all autogenerated files by ZAP + SDK

* WC: Activate Test for global attribute FeatureMap reading value

* WC: Add missing test dependancies

* WC: Add absolute positioning into FeatureMap

* Fix: Conflict on Cluster gen

* WC: Regenerate/Rebase

* WC: Regen / Rebase

* WC: Regen rebase

* Restyled by autopep8

* Restyled by autopep8

Co-authored-by: Justin Wood <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@bzbarsky-apple @JasonLiuZhuoCheng
Fix window covering XML and regen .zap files. (project-chip#11055)
0614943 
We had some changes to .xml files to rename things that were not reflected into .zap files.  Running ./scripts/tools/zap_convert_all.py fixes that, but fails before this PR because ZAP support for <tag> is broken and project-chip#9246 introduced use of <tag> in window-covering.xml.

So the changes:

1) Comment out the <tag> bits in
   src/app/zap-templates/zcl/data-model/chip/window-covering.xml.
2) Run ./scripts/tools/zap_convert_all.py to fix up the attribute names in
   the .zap files.
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@jmeg-sfy @woody-apple
@restyled-commits @carol-apple
Window Covering: Add FeatureMap (project-chip#9246)
43a7320 
* WC: Add FeatureMap inside xml + zap

* WC: Update all autogenerated files by ZAP + SDK

* WC: Activate Test for global attribute FeatureMap reading value

* WC: Add missing test dependancies

* WC: Add absolute positioning into FeatureMap

* Fix: Conflict on Cluster gen

* WC: Regenerate/Rebase

* WC: Regen / Rebase

* WC: Regen rebase

* Restyled by autopep8

* Restyled by autopep8

Co-authored-by: Justin Wood <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@bzbarsky-apple @carol-apple
Fix window covering XML and regen .zap files. (project-chip#11055)
6ded0df 
We had some changes to .xml files to rename things that were not reflected into .zap files.  Running ./scripts/tools/zap_convert_all.py fixes that, but fails before this PR because ZAP support for <tag> is broken and project-chip#9246 introduced use of <tag> in window-covering.xml.

So the changes:

1) Comment out the <tag> bits in
   src/app/zap-templates/zcl/data-model/chip/window-covering.xml.
2) Run ./scripts/tools/zap_convert_all.py to fix up the attribute names in
   the .zap files.
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@jmeg-sfy @woody-apple @restyled-commits
Window Covering: Add FeatureMap (project-chip#9246)
a865f9d 
* WC: Add FeatureMap inside xml + zap

* WC: Update all autogenerated files by ZAP + SDK

* WC: Activate Test for global attribute FeatureMap reading value

* WC: Add missing test dependancies

* WC: Add absolute positioning into FeatureMap

* Fix: Conflict on Cluster gen

* WC: Regenerate/Rebase

* WC: Regen / Rebase

* WC: Regen rebase

* Restyled by autopep8

* Restyled by autopep8

Co-authored-by: Justin Wood <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Fix window covering XML and regen .zap files. (project-chip#11055)
c0008ab 
We had some changes to .xml files to rename things that were not reflected into .zap files.  Running ./scripts/tools/zap_convert_all.py fixes that, but fails before this PR because ZAP support for <tag> is broken and project-chip#9246 introduced use of <tag> in window-covering.xml.

So the changes:

1) Comment out the <tag> bits in
   src/app/zap-templates/zcl/data-model/chip/window-covering.xml.
2) Run ./scripts/tools/zap_convert_all.py to fix up the attribute names in
   the .zap files.
@jmeg-sfy jmeg-sfy deleted the jmeg-sfy/window-covering-add-featuremap branch December 10, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@LuDuda LuDuda LuDuda approved these changes

@woody-apple woody-apple woody-apple approved these changes

@selissia selissia selissia approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@hawk248 hawk248 Awaiting requested review from hawk248

@msandstedt msandstedt Awaiting requested review from msandstedt

@chulspro chulspro Awaiting requested review from chulspro

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app controller darwin examples fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncomment and fill properly once FEATURE MAP available
8 participants
@jmeg-sfy @woody-apple @andy31415 @LuDuda @selissia @bzbarsky-apple @jmartinez-silabs @restyled-commits