Add Replaceable Monitoring Cluster Definition #26431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the code on macOS the java files cannot be formated due to the missing formatter. This commit regenerated the code inside a linux devcontainer which has the required tools and therefore formats the java files correctly.
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
franck-apple
|
PR #26431: Size comparison from 4f081a5 to 0ccbd6e Increases above 0.2%:
Increases (5 builds for bl702, cc32xx, linux)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, cc32xx, nrfconnect)
Full report (23 builds for bl602, bl702, cc13x2_26x2, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
…ing-cluster-definition
|
PR #26431: Size comparison from ee81b19 to 5344322 Increases above 0.2%:
Increases (9 builds for bl702, cc32xx, linux, psoc6)
Decreases (9 builds for bl602, bl702, cc32xx, psoc6, qpg)
Full report (24 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg)
|
src/app/zap-templates/zcl/data-model/chip/replacable-monitoring-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/replacable-monitoring-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/replacable-monitoring-cluster.xml
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/replacable-monitoring-cluster.xml
Outdated
Show resolved
Hide resolved
|
PR #26431: Size comparison from bb3ce44 to 0e0f212 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #26431: Size comparison from bb3ce44 to 108f94f Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
- Defines need to be the attribute name not the cluster name - Optionality was missing
Defines should match other defines in the SDK. The pattern was missing the _CLUSTER suffix
ZAP does not really well handle things if cluster defines get renamed 😱
|
PR #26431: Size comparison from 023b023 to 1b3ccd5 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 12, 2023
… 26223-add-replaceable-monitoring-cluster-definition # Conflicts: # src/controller/java/generated/java/chip/devicecontroller/ClusterReadMapping.java
andy31415
reviewed
May 12, 2023
|
PR #26431: Size comparison from bbff46a to f82cdf4 Increases above 0.2%:
Increases (25 builds for bl702, cc32xx, efr32, esp32, linux, nrfconnect, psoc6)
Decreases (7 builds for bl702, cc32xx, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
…ing-cluster-definition
|
PR #26431: Size comparison from 5f1a60b to 4a0892a Increases above 0.2%:
Increases (30 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (15 builds for bl702, cc32xx, esp32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
May 16, 2023
tianfeng-yang
pushed a commit
to tianfeng-yang/connectedhomeip
that referenced
this pull request
May 17, 2023
* Add Replacable Monitoring Cluster Definition * Add Cluster Definition to Relevant Lists * Enable New Clusters in Darvin and Android Clients * Add Clusters to Cluster List * Add Generated Code * Fix Code Formatting for Java Files When generating the code on macOS the java files cannot be formated due to the missing formatter. This commit regenerated the code inside a linux devcontainer which has the required tools and therefore formats the java files correctly. * Add Cluster Definition to CI Tests * Add Missing Cluster in Cluster List * Fix Java Code Gen * Revert Parameter Re-Ordering In order to keep the delta minimal the arguments to that script should not be re-ordered alphabetically. * Add Cluster Definition to CI Tests * Revert Re-Ordering * Add New Cluster * Revert Re-Ordering * Add New Cluster * Re-Add Changes The changes got lost during pre-re-ordering reconstruction. This commit re-introduces those chanes. * Revert Re-Sorting * Revert Re-Ordering * Re-Add Changes The changes got lost during pre-re-ordering reconstruction. This commit re-introduces those chanes. * Add Expected Generated Files * Update Generated Code * Update Feature Map Name * Move Line to Nearly Correct Position 😅 * Fix Attribute Definitions - Defines need to be the attribute name not the cluster name - Optionality was missing * Update Cluster Defines Defines should match other defines in the SDK. The pattern was missing the _CLUSTER suffix * Fix ZAP File ZAP does not really well handle things if cluster defines get renamed 😱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR adds the replaceable monitoring cluster definition (
replaceable-monitoring-cluster.xml) zap template.🔎 Details
zap_regen_all.py🧪 How Has This Been Tested
./scripts/examples/gn_build_example.sh examples/chip-tool out/chip-tool🔗 Links/References